From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbeACCxH (ORCPT + 1 other); Tue, 2 Jan 2018 21:53:07 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55226 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbeACCxF (ORCPT ); Tue, 2 Jan 2018 21:53:05 -0500 Date: Tue, 02 Jan 2018 21:53:03 -0500 (EST) Message-Id: <20180102.215303.688959532079579900.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, privat@egil-hjelmeland.no, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value From: David Miller In-Reply-To: <20171229190545.21109-1-f.fainelli@gmail.com> References: <20171229190545.21109-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Jan 2018 18:53:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Florian Fainelli Date: Fri, 29 Dec 2017 11:05:45 -0800 > We need to make the dsa_legacy_register() stub return 0 in order for > dsa_init_module() to successfully register and continue registering the > ETH_P_XDSA packet handler. > > Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support") > Reported-by: Egil Hjelmeland > Signed-off-by: Florian Fainelli Applied, thanks Florian.