From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbeACHha (ORCPT + 1 other); Wed, 3 Jan 2018 02:37:30 -0500 Received: from mail-eopbgr50097.outbound.protection.outlook.com ([40.107.5.97]:10776 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751185AbeACHh1 (ORCPT ); Wed, 3 Jan 2018 02:37:27 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=avagin@virtuozzo.com; Date: Tue, 2 Jan 2018 23:37:05 -0800 From: Andrei Vagin To: syzbot Cc: Jason@zx2c4.com, akpm@linux-foundation.org, alexander.deucher@amd.com, avagin@openvz.org, chris@chris-wilson.co.uk, davem@davemloft.net, dsahern@gmail.com, edumazet@google.com, elena.reshetova@intel.com, gregkh@linuxfoundation.org, herbert@gondor.apana.org.au, johannes.berg@intel.com, linux-kernel@vger.kernel.org, lucien.xin@gmail.com, mchehab@kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: general protection fault in __netlink_ns_capable Message-ID: <20180103073703.GA30495@outlook.office365.com> References: <001a113f90208881610561cfadcf@google.com> <20180103003508.GA16712@outlook.office365.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20180103003508.GA16712@outlook.office365.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [73.140.212.29] X-ClientProxiedBy: CY4PR13CA0041.namprd13.prod.outlook.com (2603:10b6:903:99::27) To VI1PR08MB0749.eurprd08.prod.outlook.com (2a01:111:e400:5a04::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6752392-e740-457f-a579-08d5527cd3b7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:VI1PR08MB0749; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0749;3:f2G1wezGdTDsaxrECB/8kKMH4mFmeDbRh7Q385ffOYD1BqaD9f0CFWRSciVxZbSI0lklJJqZoBFXkY7Jo867/N8R0OPBhUfDM4x0YjAPYMZoOia9h0FUat/sgqfuvI7BeIkutnGMF69qhmz73L8ATOu0hWjUvfvgFUoMwOETuJSS5uc561UczDvpj7bAvI3Wmq05Lt5nNkuXSbWqDyiCZMGTmCN3TOXsCmdUy2/mQO+Fusb8wT/JeQv+a3bPqsYf;25:+zgwUjGa3GFZAv5Rjglb6RIMsW5LvIK4k50HekLAPzXPUtj3yUrmJb75JoWnAAyOSXvHf4Tjr5US9Jj60NdRFeEJyjaTurfmNV+0b+sEIG2sfTiiIkvS5Ww3pIvSaIS3ptNl/no/SLEQQcjAFSC8ReMxG7OmGruoclJAxK0XiC0eb9qiwNzDF8I2TBNtCi7PFR/5Nkt8M7Wkf3weR0bedTSlOBIR0nocERXBsRuXLoo+3CT13Omg2wP5R68Xe36SBt2g87vIZ4wXnnQ7vNpN9HpOLbcp1Zm1JRQ9iknaK1jWqx0wc+zBGaxZVsKF0ldKGoBYyRghslIp/5C3RirKQA==;31:ZWZCgw+GJ1KUvNYXPAnnXt1tf8HSR5zw+chTZvKzYVKi/xdAqc+b/oA6yafZ6ECUuYFiNqiUGwvRD3HsvpSwEXNimj7SecPyzDRukW5hajm+Uf5gmBrv63TYY53L/zTeBmKLeqQBiSqZGLzrChsP0aVxjUF4Vjs6yzlJygpm48xR4kxQ9FNhBsvGHLEpnnnj1ltxBCPgLiuGcsHelGFZdzVE+0/6DmHU02hRGObJEKw= X-MS-TrafficTypeDiagnostic: VI1PR08MB0749: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0749;20:uwBiUVI/qHW9TwHdGPTJFhEiUmzaeWN3ZnxYVx85OUHLDz7AdR5EY2HDwxwtRS+ap6Zp3HGal5blkuWcgCvbGJRqsEMdTVQksQZ0dN5jEtd+tVZ8DD+r0mppRXWNEiRZyBztW+Zx96FQeqZq/rN54Iw9X9T5tWBJXtg5UqFyqY2BN/jw1oho2jiLi9iGBjsYDFFVRMOaLGe/4/Phz/zaGS0iZQ5U7BZ5jKM6Vundb5jAujmvfOURqD+v0W4+gXis5k/Ux22unc1ahHVFaz9jg09dkMai0cMy7tIizYTUBh67j0TzdcWwUKgQSwHS937qGgLlwxwr8R6SCFF8BnN+d2MWwyuJZdW41GnE2BLb+1o5bFLtImPrCphwg3+OBFiABtL9QTLs7LO8yWszxfRLDM1/p2Rv2qhmaBAT8Jn4WHg=;4:f33bndUeak22aruUpteN+VW8/PTMn/Kl32Xo3lMfCatyMhzM23ng7TvxYGXZriRp+5RE+GDcpFRFDRJmmGQJxvmNpWADj9mtsmCLtLaBP4YGl3yLeeGKMeAa6x42FagSdQw3qrg2uTRGpyiZJlP1a7R879stjR3yPIbk9dk1kWtvktj67GNbSAUuCDue46rsI7/7zA53N2mI3Qg8fLaUXmY7hnW2801pQsyRI8pOuQEReQ4XWInTDcrXhK1ER/JOHA2O0MMKI7a9pGd+bJ+eGg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231023)(944501075)(3002001)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011);SRVR:VI1PR08MB0749;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR08MB0749; X-Forefront-PRVS: 0541031FF6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(366004)(346002)(39840400004)(376002)(39380400002)(396003)(24454002)(199004)(189003)(47776003)(16526018)(66066001)(68736007)(305945005)(45080400002)(59450400001)(229853002)(5890100001)(7736002)(83506002)(39060400002)(7696005)(25786009)(106356001)(16586007)(105586002)(316002)(69596002)(58126008)(52116002)(50466002)(9686003)(55016002)(6246003)(8666007)(81156014)(6306002)(478600001)(966005)(8676002)(2906002)(53936002)(86362001)(6666003)(33656002)(53416004)(7416002)(4326008)(386003)(6506007)(1076002)(3846002)(6116002)(76176011)(11609785009)(2950100002)(5660300001)(23686003)(81166006)(97736004)(8936002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB0749;H:outlook.office365.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;VI1PR08MB0749;23:mbQTcMkL6LOiUaYNWweE0ejj6fgp4WNcfK0Wzd3NmJn?= =?koi8-r?Q?FcgedOK+47S4YSpWcFliYk9sU7XCzAJs3ZBM9epGh8leNo7FYRmj9D3j8rUU2r?= =?koi8-r?Q?YK9XOQq2aZPRFmN1xeNsTUYSxGNki6uYGJC8dApzNdd5HE8s6pg6iWse10Jxrs?= =?koi8-r?Q?1liKHf1/sLUWwfk/NqLEiSFgw8FbJ1GXBPPFHO/BjkHUKmp6ylv8QEvacvB3x3?= =?koi8-r?Q?5kmN0B4S75NAGWCDzmw/i6SKodaoS+Hi/3SrP2zTTC3IhCFGar0gI99t8JfsGG?= =?koi8-r?Q?IrEnPvW8O3J0gy3igyRE7D0s4ydHqJSInOP9dt8pNiAAu0o6azOOM0U7nYfU4Y?= =?koi8-r?Q?wYHDEh57C5uh0RYLJ3fqT8aVZGP80A16/DcrSpxcHAln605HzyEmDJN742nkOd?= =?koi8-r?Q?7qS/FD/2rHnJIFryZNyJ5aBAJJ8WyiI1WudPN5LD8gR3iR51+WL0QvBQmY0AM8?= =?koi8-r?Q?3SgMKxMxqV2h41Mm/A8xfud1TWL3qpWEm43Sb+1vBZ8j8lZpWai9U2NNBN7zQ4?= =?koi8-r?Q?a2Ed/f16C+Uvk7FDa4y+lZeYTojIETN7mvcKw6pqWRiDp/v5Wjk9ex2/NLjhOD?= =?koi8-r?Q?Ydflbyiwb+CkdrhP213V49DdzwnVTfyH7UXk0BcPJRsvy5l01bwPkE/AWlyWS0?= =?koi8-r?Q?fyy+wGpsJjs2oVAcbYwLPcSnwsM18sSWXbXtbSRpFNIGcbdaGYCT/PazJD0Fma?= =?koi8-r?Q?1A0ZCDwM34BdYS0ZEcnQcJ4ZcPcoToemtAEZS5imAdVRPdvN5fr2mgfS9fBBTc?= =?koi8-r?Q?OWHjBj/aiPG7oNByXsEwwjNQ50GgcNzqwE5HEXHv+tv43DjY+21AqsAPS2D7Yt?= =?koi8-r?Q?0k+Sbm7CsDkLa2VldI+uL7gWCchWVxsx3Njcp59WexqM/t9OSADsujVrqyESlm?= =?koi8-r?Q?cmMH/vlizpFZ7PaQp0GYKKhqLRIJkiHmVT9Fo6DLAzt5UpLFz7624oToEHnR45?= =?koi8-r?Q?8Qy1pzdvVSsu668xPrKlDlYNmJcL/l3pgue1XdAJDbdySwQEB3wytiCXGPH3dm?= =?koi8-r?Q?U8tDufThYr+YS//W7vznEPMTIKU0233czSo+CnI3eKkkRi/A5G49uzvzvgHPb8?= =?koi8-r?Q?kSB39k4ccZNxve1e0dpzHbK+3AIs8S8oAcDIQkiyXu41V4LxlM7J7IswNwFWsU?= =?koi8-r?Q?gnsSIOpQ/NI2e1+paLy7m56Ya3vJXJhVOawNzE572+EQUPMyw6TITfFrmm78xl?= =?koi8-r?Q?lbJ1bE89mGhbzgTwWrA2hf+ehX1QEF/eO5aEdilcoBpnaAe9E091SoFc9E8zlM?= =?koi8-r?Q?pWBjZ5/RkYf77KKON8brz8p3drViAezVQOjh7cKbz7+dpFxTGOMqu8xxZoxvc1?= =?koi8-r?Q?aizm4hXQK3VQA22bHbIMNXCLArfpcYPCWcSDaPVTnWQBtCigHGVihXx4ek+wKP?= =?koi8-r?Q?kmNLtzbhB4+0oMbHGY/bTvA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0749;6:4Ybe/FQwzRIRgNSK4xo34mSA0rWFlX1qkjVBtF0qxnKIxHyBLKxS6lXwjohdMaJsSEKmeafSGIzeTCjsA8ZJjfyYMNEuqol5QNmbBckCXoiAnGGmNis+AN6NZkqKkS3UuiG+rJcXvnjFbY5UYUNmO/2Jxdm/REiHpYBm0LIX0kSQE0d1qUugMO5R9eyl0CAqv0aTgbV7W/98C/O2ej8uG3Fwmn149qRlyL9D2Uwq3fVlDgUBr93V6bl0GvZXkGUOQ382MR5kWmIR2H9d6EvG+R5d+soqx2JbZjO0N5SGFW8YpgZqMjyYtd38r3GYcGal8jY1xYRyVYhR76K1rjjiING8UIOQf7o/9MHXmmwonj4=;5:iKsCX1vQoy0R5refs3KlvO2LB7JlpEdInF5F+Bk0mDm+seLfCFRvB7ZLtG88n8IpL88hoUoa1ZVFuoYBdH4wHCTWB85bUqEjzFOewhcfEamXlijRd/zwKYuZ9aNmgiLO8+dl9Xedz+yI0XgIvbMUw69jUqUKXb6v35xjeJABPRM=;24:6E5kz5kl8Y2waoMu+ELjEl9QznLAjDyMDdPwBSxkZkgBzJLvGvRcOPJrbsTAcxqwTiL87jnLMxW4VgUeE+hE/GeOOx3t+a87ftmdvSgF8JE=;7:MebX9V4xfVsk1X+P39WqQ2n5KHNjosCrmhjLrvg0kA5K5mZ/Sd75vq02pg/OLQQWszfPsfXd7R28lvrAaUt3ElpwstWwP8I6E3JZVutEQOGIZtGGkAyyPdS8Uj2TrfEHuE7mYVJrBLw2rqV7NLdzPHOl3N7+6O/m94h12IArFKyszF2N9x8wbyjqISzqdU58aX/sqPOLdiqLxY8vL09EaMIBqAcj1+UZwdy0wTiH6kBmAS60KIXjVoRvkzpAXfU2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0749;20:8wOUEu6fz9td/8sgw/5saxeo2XYwyN5XI/9Vm805TH6PUin4Mav6MH3h8RCQJGT9yQ+iJZqq9VI9X6l7UqEF0h9tTMNLyEhfoEPLGeRr1X94j+zoHnKGUnGiuZ4Rt+W39TQhpK1Cf0PBM9c96Dkx9bfggVFDH27BdG8+2a743Qo= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2018 07:37:18.1742 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6752392-e740-457f-a579-08d5527cd3b7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0749 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 02, 2018 at 04:35:11PM -0800, Andrei Vagin wrote: > On Tue, Jan 02, 2018 at 10:58:01AM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 75aa5540627fdb3d8f86229776ea87f995275351 > > git://git.cmpxchg.org/linux-mmots.git/master > > compiler: gcc (GCC) 7.1.1 20170620 > > .config is attached > > Raw console output is attached. > > C reproducer is attached > > syzkaller reproducer is attached. See https://goo.gl/kgGztJ > > for information about syzkaller reproducers > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+e432865c29eb4c48c142@syzkaller.appspotmail.com > > It will help syzbot understand when the bug is fixed. See footer for > > details. > > If you forward the report, please keep this part and the footer. > > > > netlink: 3 bytes leftover after parsing attributes in process > > `syzkaller140561'. > > netlink: 3 bytes leftover after parsing attributes in process > > `syzkaller140561'. > > netlink: 3 bytes leftover after parsing attributes in process > > `syzkaller140561'. > > kasan: CONFIG_KASAN_INLINE enabled > > kasan: GPF could be caused by NULL-ptr deref or user memory access > > general protection fault: 0000 [#1] SMP KASAN > > Dumping ftrace buffer: > > (ftrace buffer empty) > > Modules linked in: > > CPU: 1 PID: 3149 Comm: syzkaller140561 Not tainted 4.15.0-rc4-mm1+ #47 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > Google 01/01/2011 > > RIP: 0010:__netlink_ns_capable+0x8b/0x120 net/netlink/af_netlink.c:868 > > NETLINK_CB(skb).sk is NULL here. It looks like we have to use > sk_ns_capable instead of netlink_ns_capable: > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index c688dc564b11..408c75de52ea 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -1762,7 +1762,7 @@ static struct net *get_target_net(struct sk_buff > *skb, int netnsid) > /* For now, the caller is required to have CAP_NET_ADMIN in > * the user namespace owning the target net ns. > */ > - if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) { > + if (!sk_ns_capable(skb->sk, net->user_ns, CAP_NET_ADMIN)) { > put_net(net); > return ERR_PTR(-EACCES); > } > get_target_net() is used twice in the code. In rtnl_getlink(), we need to use netlink_ns_capable(skb, ...), but in rtnl_dump_ifinfo, we need to use sk_ns_capable(skb->sk, ...). Pls, take a look at this patch: https://patchwork.ozlabs.org/patch/854896/ Subject: rtnetlink: give a user socket to get_target_net()