From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Ryan Lee <RyanS.Lee@maximintegrated.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>, "afd@ti.com" <afd@ti.com>,
"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
"supercraig0719@gmail.com" <supercraig0719@gmail.com>,
"jbrunet@baylibre.com" <jbrunet@baylibre.com>,
"dannenberg@ti.com" <dannenberg@ti.com>,
"romain.perier@collabora.com" <romain.perier@collabora.com>,
"bryce.ferguson@rockwellcollins.com"
<bryce.ferguson@rockwellcollins.com>,
"m-stecklein@ti.com" <m-stecklein@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>
Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver
Date: Wed, 3 Jan 2018 16:57:42 +0000 [thread overview]
Message-ID: <20180103165742.GH28713@sirena.org.uk> (raw)
In-Reply-To: <87k1xah0e5.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Mon, Dec 25, 2017 at 11:17:29PM +0000, Kuninori Morimoto wrote:
> Having private regmap seems a little bit duplicate for me,
> because we can get it from component or dev.
> But sometimes, in some drivers, it seems can be difficult.
> Sorry for my noise.
It is duplication but if you've only got the dev then it makes things a
bit faster as the call to look up a regmap from a dev is relatively
expensive. That's not the case for components though where it's just a
straight variable lookup so it's more a case of how clean the code looks
and preference there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-03 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 1:43 Ryan Lee
2017-12-22 2:24 ` Kuninori Morimoto
2017-12-25 14:30 ` Ryan Lee
2017-12-25 23:17 ` Kuninori Morimoto
2018-01-03 16:57 ` Mark Brown [this message]
2017-12-22 8:39 ` Philippe Ombredanne
2017-12-25 14:30 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103165742.GH28713@sirena.org.uk \
--to=broonie@kernel.org \
--cc=RyanS.Lee@maximintegrated.com \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=bryce.ferguson@rockwellcollins.com \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-stecklein@ti.com \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=romain.perier@collabora.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=supercraig0719@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®