From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbeADTCc (ORCPT + 1 other); Thu, 4 Jan 2018 14:02:32 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49688 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbeADTC2 (ORCPT ); Thu, 4 Jan 2018 14:02:28 -0500 Date: Thu, 04 Jan 2018 14:02:26 -0500 (EST) Message-Id: <20180104.140226.949194351555593980.davem@davemloft.net> To: jbrunet@baylibre.com Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only From: David Miller In-Reply-To: <20180103154629.1433-1-jbrunet@baylibre.com> References: <20180103154629.1433-1-jbrunet@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Jan 2018 11:02:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Jerome Brunet Date: Wed, 3 Jan 2018 16:46:29 +0100 > Note in the databook - Section 4.4 - EEE : > " The EEE feature is not supported when the MAC is configured to use the > TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC > supports multiple PHY interfaces, you should activate the EEE mode only > when the MAC is operating with GMII, MII, or RGMII interface." > > Applying this restriction solves a stability issue observed on Amlogic > gxl platforms operating with RMII interface and the internal PHY. > > Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported") > Signed-off-by: Jerome Brunet > Tested-by: Arnaud Patard Applied and queued up for -stable, thanks.