From: maxime.ripard@free-electrons.com
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 05/11] ARM: sun8i: h3/h5: add DE2 CCU device node for H3
Date: Thu, 4 Jan 2018 14:39:47 +0100 [thread overview]
Message-ID: <20180104133947.slerf6m52suarmym@flea.lan> (raw)
In-Reply-To: <20171222122243.25735-6-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Fri, Dec 22, 2017 at 08:22:37PM +0800, Icenowy Zheng wrote:
> The DE2 in H3/H5 has a clock control unit in it, and the behavior is
> slightly different between H3 and H5.
>
> Add the common parts in H3/H5 DTSI, and add the compatible string in H3
> DTSI.
>
> The compatible string of H5 DE2 CCU will be added in a separated patch.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Changes in v2:
> - Use H3 DE2 CCU compatible as it's discovered that H3 and A83T DE2 CCU are
> not equal.
>
> arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 14 ++++++++++++++
Could you split that patch in half, with the common part in one patch,
and the H3 part in a second one?
This is a nightmare to merge otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-04 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 12:22 [PATCH v3 00/11] Allwinner H3/H5/A64(DE2) SimpleFB support Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 01/11] dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3 Icenowy Zheng
2017-12-26 19:00 ` Rob Herring
2017-12-22 12:22 ` [PATCH v3 02/11] clk: sunxi-ng: add support for Allwinner H3 DE2 CCU Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 03/11] clk: sunxi-ng: fix the A64/H5 clock description of " Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 04/11] dt-bindings: simplefb-sunxi: add pipelines for DE2 Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 05/11] ARM: sun8i: h3/h5: add DE2 CCU device node for H3 Icenowy Zheng
2018-01-04 13:39 ` maxime.ripard [this message]
2017-12-22 12:22 ` [PATCH v3 06/11] arm64: allwinner: h5: add compatible string for DE2 CCU Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 07/11] ARM: sunxi: h3/h5: add simplefb nodes Icenowy Zheng
2017-12-29 8:45 ` Chen-Yu Tsai
2017-12-22 12:22 ` [PATCH v3 08/11] dt-bindings: add binding for A64 DE2 CCU SRAM Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 09/11] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU Icenowy Zheng
2017-12-29 8:35 ` Chen-Yu Tsai
2018-01-04 13:41 ` Maxime Ripard
2017-12-22 12:22 ` [PATCH v3 10/11] arm64: allwinner: a64: add DE2 CCU for A64 SoC Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 11/11] arm64: allwinner: a64: add simplefb " Icenowy Zheng
2017-12-27 4:09 ` [PATCH v3 00/11] Allwinner H3/H5/A64(DE2) SimpleFB support Chen-Yu Tsai
2017-12-27 4:10 ` Icenowy Zheng
2017-12-27 4:23 ` Chen-Yu Tsai
2017-12-29 8:52 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104133947.slerf6m52suarmym@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®