From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753443AbeADPlK (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 4 Jan 2018 10:41:10 -0500
Received: from mx2.suse.de ([195.135.220.15]:47773 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751770AbeADPlJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Jan 2018 10:41:09 -0500
Date: Thu, 4 Jan 2018 16:40:18 +0100
From: Jan Kara <jack@suse.cz>
To: Colin King <colin.king@canonical.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement
Message-ID: <20180104154018.GB2170@quack2.suse.cz>
References: <20171129142059.21898-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171129142059.21898-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed 29-11-17 14:20:59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The indentation is incorrect and spaces need replacing with a tab
> on the if statement.
> 
> Cleans up smatch warning:
> fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This seems to fall through cracks. The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza


> ---
>  fs/ext4/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 798b3ac680db..d3fabc553c65 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3217,8 +3217,8 @@ static int ext4_link(struct dentry *old_dentry,
>  	if (err)
>  		return err;
>  
> -       if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> -	   (!projid_eq(EXT4_I(dir)->i_projid,
> +	if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> +	    (!projid_eq(EXT4_I(dir)->i_projid,
>  		       EXT4_I(old_dentry->d_inode)->i_projid)))
>  		return -EXDEV;
>  
> -- 
> 2.14.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR