From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbeADQGJ (ORCPT + 1 other); Thu, 4 Jan 2018 11:06:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbeADQGH (ORCPT ); Thu, 4 Jan 2018 11:06:07 -0500 Date: Thu, 4 Jan 2018 10:06:01 -0600 From: Josh Poimboeuf To: Andi Kleen Cc: Andi Kleen , tglx@linutronix.de, torvalds@linux-foundation.org, gregkh@linux-foundation.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com Subject: Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings Message-ID: <20180104160601.w2l2wdabuxa26xzq@treble> References: <20180104020019.1173-1-andi@firstfloor.org> <20180104020019.1173-12-andi@firstfloor.org> <20180104143814.bhvtsjiwpyhtgjph@treble> <20180104155914.GL25156@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180104155914.GL25156@tassilo.jf.intel.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 04 Jan 2018 16:06:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 04, 2018 at 07:59:14AM -0800, Andi Kleen wrote: > > NAK. We can't blindly disable objtool warnings, that will break > > livepatch and the ORC unwinder. If you share a .o file (or the GCC > > code) I can look at adding retpoline support. > > I don't think we can wait for that. We can disable livepatch and the > unwinder for now. They are not essential. Frame pointers should work > well enough for unwinding If you want to make this feature conflict with livepatch and ORC, silencing objtool warnings is not the way to do it. > and afaik nobody can use livepatch in mainline anyways. Why not? The patch creation tooling is still out-of-tree, but livepatch itself is fully supported in mainline. -- Josh