mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org,
	vinod.koul@intel.com, liam.r.girdwood@linux.intel.com,
	andriy.shevchenko@linux.intel.com, arnd@arndb.de,
	linux-kernel@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH v3 01/10] ASoC: acpi: add missing includes for non-ACPI platforms
Date: Thu,  4 Jan 2018 16:35:52 -0600	[thread overview]
Message-ID: <20180104223601.5831-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20180104223601.5831-1-pierre-louis.bossart@linux.intel.com>

0-day reports compilation issues with non-ACPI platforms.

In file included from sound/soc/soc-acpi.c:17:0:
>> include/sound/soc-acpi.h:36:46: error: 'ACPI_ID_LEN' undeclared here
(not in a function); did you mean 'ACPI_FILE'?
    snd_soc_acpi_find_name_from_hid(const u8 hid[ACPI_ID_LEN])

 sound/soc/soc-acpi.c: At top level:
>> sound/soc/soc-acpi.c:174:16: error: expected declaration specifiers or
'...' before string constant
    MODULE_LICENSE("GPL v2");

Add missing include files.

Fixes: 7feb2f786a46 ("ASoC: move ACPI common code out of Intel/sst tree")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/sound/soc-acpi-intel-match.h | 1 +
 include/sound/soc-acpi.h             | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/sound/soc-acpi-intel-match.h b/include/sound/soc-acpi-intel-match.h
index 1a9191cd4bb3..9da6388c20a1 100644
--- a/include/sound/soc-acpi-intel-match.h
+++ b/include/sound/soc-acpi-intel-match.h
@@ -16,6 +16,7 @@
 #ifndef __LINUX_SND_SOC_ACPI_INTEL_MATCH_H
 #define __LINUX_SND_SOC_ACPI_INTEL_MATCH_H
 
+#include <linux/module.h>
 #include <linux/stddef.h>
 #include <linux/acpi.h>
 
diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h
index a7d8d335b043..a93436089bf5 100644
--- a/include/sound/soc-acpi.h
+++ b/include/sound/soc-acpi.h
@@ -17,6 +17,7 @@
 
 #include <linux/stddef.h>
 #include <linux/acpi.h>
+#include <linux/mod_devicetable.h>
 
 struct snd_soc_acpi_package_context {
 	char *name;           /* package name */
-- 
2.14.1

  reply	other threads:[~2018-01-04 22:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 22:35 [PATCH v3 00/10] ASoC: Intel: Kconfig+acpi fixes Pierre-Louis Bossart
2018-01-04 22:35 ` Pierre-Louis Bossart [this message]
2018-01-04 22:35 ` [PATCH v3 02/10] ASoC: Intel: Fix Kconfig with top-level selector Pierre-Louis Bossart
2018-01-04 22:35 ` [PATCH v3 03/10] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2018-01-04 22:35 ` [PATCH v3 04/10] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2018-01-04 22:35 ` [PATCH v3 05/10] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2018-01-08 16:22   ` Applied "ASoC: Intel: Fix nested/unnecessary Kconfig dependencies" to the asoc tree Mark Brown
2018-01-04 22:35 ` [PATCH v3 06/10] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-04 22:35 ` [PATCH v3 07/10] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2018-01-04 22:35 ` [PATCH v3 08/10] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2018-01-08 16:21   ` Applied "ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs" to the asoc tree Mark Brown
2018-01-04 22:36 ` [PATCH v3 09/10] ASoC: Intel: kconfig: add some comments for if symbols Pierre-Louis Bossart
2018-01-08 16:21   ` Applied "ASoC: Intel: kconfig: add some comments for if symbols" to the asoc tree Mark Brown
2018-01-04 22:36 ` [PATCH v3 10/10] ASoC: Intel: kconfig: drop boiler plate text from config items Pierre-Louis Bossart
2018-01-08 16:21   ` Applied "ASoC: Intel: kconfig: drop boiler plate text from config items" to the asoc tree Mark Brown
2018-01-08  4:47 ` [PATCH v3 00/10] ASoC: Intel: Kconfig+acpi fixes Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104223601.5831-2-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®