From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751776AbeAEMWu (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 5 Jan 2018 07:22:50 -0500
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34556 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750907AbeAEMWs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Jan 2018 07:22:48 -0500
Date: Fri, 5 Jan 2018 12:22:42 +0000
From: Mark Brown <broonie@kernel.org>
To: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo
 Semiconductor's TSCS42xx audio CODEC
Message-ID: <20180105122242.GC9076@sirena.org.uk>
References: <20171219205415.wlu4atv2mdy7i3gb@localhost.localdomain>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="V88s5gaDVPzZ0KCq"
Content-Disposition: inline
In-Reply-To: <20171219205415.wlu4atv2mdy7i3gb@localhost.localdomain>
X-Cookie: Prunes give you a run for your money.
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


--V88s5gaDVPzZ0KCq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 19, 2017 at 02:54:25PM -0600, Steven Eckhoff wrote:

> +	SOC_ENUM("MBC Band1 Level Detect Switch",
> +		mbc_level_detection_enums[0]),
> +	SOC_ENUM("MBC Band2 Level Detect Switch",
> +		mbc_level_detection_enums[1]),
> +	SOC_ENUM("MBC Band3 Level Detect Switch",
> +		mbc_level_detection_enums[2]),
> +	SOC_ENUM("MBC Band1 Level Detect Win Switch",
> +		mbc_level_detection_window_enums[0]),
> +	SOC_ENUM("MBC Band2 Level Detect Win Switch",
> +		mbc_level_detection_window_enums[1]),
> +	SOC_ENUM("MBC Band3 Level Detect Win Switch",
> +		mbc_level_detection_window_enums[2]),

These are enums so they should probably not have Switch at the end of
their name, I suspect that might confuse userspace somehow.

> +	SOC_SINGLE("MBC1 Phase Invert", R_DACMBCMUG1, FB_DACMBCMUG1_PHASE,
> +		1, 0),

While this is an on/off switch (for inversion) so it ought to end in
Switch.  Otherwise this driver looks good I think, just those couple of
small things so I'll apply - please send followup patches fixing.

--V88s5gaDVPzZ0KCq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlpPbhEACgkQJNaLcl1U
h9D9jwgAhOKzuJAQ5ktJQ5/D4JlXaJZmTDCjYlveWl9+L5maj4nyJKfZ8Meiuyud
0NPIcOIWHuSjaGkRgp/hbw7gUv+niyoCdJFf/k7w3A5Ep7EXIQck+L2WsrlA4+IR
pPygth2gyL63l38oqcKozPF7e7TDfhlQAFAoxI/kta+jwRaIkYc9n3cGFrAQzPCP
/i5Q8mhYkEVkplrtLMQp3T+hXYIGQ+/QH5rg7W1GZxeXyQFRWGfZgS9wPzGnOLvZ
H8iBijGiejyPzP+DemnHGSZPyPvuEyXWCWGtyYWKW5YELbuEkbs5Lk7sBHEG2X+h
1yN03qbe4b79N5o8n0QCTkeciuPY1Q==
=IshR
-----END PGP SIGNATURE-----

--V88s5gaDVPzZ0KCq--