From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbeAEQuI (ORCPT + 1 other); Fri, 5 Jan 2018 11:50:08 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:37587 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbeAEQuB (ORCPT ); Fri, 5 Jan 2018 11:50:01 -0500 X-Google-Smtp-Source: ACJfBouy0dNHPyerpFy4PC9pO4KQkrPJ4Z5O7AlFGoiD3StSaqAr46cqYpQxpaSfe4MKLp88yFnWyA== Date: Fri, 5 Jan 2018 08:49:58 -0800 From: Dmitry Torokhov To: Andi Shyti Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier Message-ID: <20180105164958.csojn6vhy72bwoac@dtor-ws> References: <20171212074149.7844-1-andi.shyti@samsung.com> <20180105095715.GA6679@gangnam.samsung> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180105095715.GA6679@gangnam.samsung> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Andi, On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > Hi Dmitry, > > this is a kind ping, would you also mind giving me a feedback to Yes, sorry. Could you please split the patch for each driver individually? Also, until we have an update to the CodingStyle doc mandating the C++ style comments, I'd prefer keeping the original style of comments. So // for the SPDX line and /* */ for the rest. Thanks! > all the previous patches I sent? Could you tell me what reviews I owe you? My mailbox keeps growing :( > > Thanks, > Andi > > On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote: > > Replace the original license statement with the SPDX identifier. > > > > Update also the copyright owner adding myself as co-owner of the > > copyright. > > > > Signed-off-by: Andi Shyti > > --- > > drivers/input/touchscreen/s6sy761.c | 15 +++++---------- > > drivers/input/touchscreen/stmfts.c | 15 +++++---------- > > 2 files changed, 10 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c > > index 26b1cb8a88ec..675efa93d444 100644 > > --- a/drivers/input/touchscreen/s6sy761.c > > +++ b/drivers/input/touchscreen/s6sy761.c > > @@ -1,13 +1,8 @@ > > -/* > > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > > - * Author: Andi Shyti > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * Samsung S6SY761 Touchscreen device driver > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > +// Samsung S6SY761 Touchscreen device driver > > +// > > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > > +// Copyright (c) 2017 Andi Shyti > > > > #include > > #include > > diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c > > index c12d01899939..2a123e20a42e 100644 > > --- a/drivers/input/touchscreen/stmfts.c > > +++ b/drivers/input/touchscreen/stmfts.c > > @@ -1,13 +1,8 @@ > > -/* > > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > > - * Author: Andi Shyti > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * STMicroelectronics FTS Touchscreen device driver > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > +// STMicroelectronics FTS Touchscreen device driver > > +// > > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > > +// Copyright (c) 2017 Andi Shyti > > > > #include > > #include > > -- > > 2.15.1 > > -- Dmitry