From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbeAGKGA (ORCPT + 1 other); Sun, 7 Jan 2018 05:06:00 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37408 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbeAGKF6 (ORCPT ); Sun, 7 Jan 2018 05:05:58 -0500 X-Google-Smtp-Source: ACJfBotTJu1bm6GUGuNP1MXCYfFQ2n2fu/RXU9iNeSoQ2Yf2iwdyYHxizet9smco9t7bof+s1Xhqvw== Date: Sun, 7 Jan 2018 11:05:53 +0100 From: Krzysztof Kozlowski To: Arnd Bergmann Cc: Rob Herring , Mark Rutland , Kukjin Kim , Marek Szyprowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: exynos: fix RTC interrupt for exynos5410 Message-ID: <20180107100553.e5lbc7tsmo7l2xyo@kozik-lap> References: <20171221213020.3080361-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171221213020.3080361-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Dec 21, 2017 at 10:30:07PM +0100, Arnd Bergmann wrote: > According to the comment added to exynos_dt_pmu_match[] in commit > 8b283c025443 ("ARM: exynos4/5: convert pmu wakeup to stacked domains"), > the RTC is not able to wake up the system through the PMU on Exynos5410, > unlike Exynos5420. > > However, when the RTC DT node got added, it was a straight copy of > the Exynos5420 node, which now causes a warning from dtc. > > This removes the incorrect interrupt-parent, which should get the > interrupt working and avoid the warning. > > Fixes: e1e146b1b062 ("ARM: dts: exynos: Add RTC and I2C to Exynos5410") > Signed-off-by: Arnd Bergmann > --- > arch/arm/boot/dts/exynos5410.dtsi | 1 - > 1 file changed, 1 deletion(-) > I reverted my commit [1] and applied yours. What is interesting... RTC works fine in any combination (so even routing interrupts through non-interrupt-controller PMU). Best regards, Krzysztof [1] https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt&id=6737b081409a4373e9d02c75aea7b916481e31b5