From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934052AbeAHPEO (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 10:04:14 -0500
Received: from userp2130.oracle.com ([156.151.31.86]:38452 "EHLO
        userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932121AbeAHPEL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 10:04:11 -0500
Date: Mon, 8 Jan 2018 18:03:39 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Luis Gerhorst <linux-kernel@luisgerhorst.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Jonny =?iso-8859-1?Q?Sch=E4fer?= <schaefer.jonny@gmail.com>,
        linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else
Message-ID: <20180108150339.3jstz64fbawef45i@mwanda>
References: <1515405997-12563-1-git-send-email-linux-kernel@luisgerhorst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1515405997-12563-1-git-send-email-linux-kernel@luisgerhorst.de>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8767 signatures=668652
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=764
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.0.1-1711220000 definitions=main-1801080217
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote:
> The Linux kernel coding style states that braces should only be used
> when necessary.
> 
> This fixes the checkpatch warning
> 
> WARNING: line over 80 characters
> +	} else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
> 
> introduced by patch #1.
> 

Don't introduce warnings and then fix them in later patches.

Anyway there is another unwritten rule that multi-line indents get curly
braces.  Probably it should be:


	} else if (display->regwidth == 8 && display->buswidth == 9 &&
		   par->spi) {

regards,
dan carpenter