From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934393AbeAHQHB (ORCPT + 1 other); Mon, 8 Jan 2018 11:07:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:54426 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242AbeAHQHA (ORCPT ); Mon, 8 Jan 2018 11:07:00 -0500 Date: Mon, 8 Jan 2018 17:06:46 +0100 From: Borislav Petkov To: Arnd Bergmann Cc: "kernelci.org bot" , Kernel Build Reports Mailman List , Hugh Dickins , Greg Kroah-Hartman , Linux Kernel Mailing List , the arch/x86 maintainers , "4.4.x" Subject: Re: stable-rc/linux-4.4.y build: 178 builds: 7 failed, 171 passed, 8 errors (v4.4.110-23-g49278737d445) Message-ID: <20180108160646.tqdgojirykmhsezn@pd.tnic> References: <5a537ac1.b0abdf0a.c8456.4e12@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 03:43:11PM +0100, Arnd Bergmann wrote: > This comes from 0cbf2b590bea ("Map the vsyscall page with _PAGE_USER") > which adds a line 'bool vsyscall_enabled(void) { return false; }' that > presumably > should have been 'static inline'. Yeah, thanks Arnd. @Greg, please fold this in: --- diff --git a/arch/x86/include/asm/vsyscall.h b/arch/x86/include/asm/vsyscall.h index d10cabb..4865e10 100644 --- a/arch/x86/include/asm/vsyscall.h +++ b/arch/x86/include/asm/vsyscall.h @@ -19,7 +19,7 @@ static inline bool emulate_vsyscall(struct pt_regs *regs, unsigned long address) { return false; } -bool vsyscall_enabled(void) { return false; } +static inline bool vsyscall_enabled(void) { return false; } #endif #endif /* _ASM_X86_VSYSCALL_H */ --- -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --