From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757093AbeAIFXg (ORCPT + 1 other); Tue, 9 Jan 2018 00:23:36 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:29178 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbeAIFXe (ORCPT ); Tue, 9 Jan 2018 00:23:34 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180109052332epoutp03c78f7303b9288d222debb6253002ede5~IDNuu3P4B1042310423epoutp03L X-AuditID: b6c32a47-5ebff70000001126-4d-5a5451d3fda3 MIME-version: 1.0 Content-disposition: inline Content-type: text/plain; charset="utf-8" Date: Tue, 09 Jan 2018 14:23:31 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Philippe Ombredanne Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier Message-id: <20180109052331.GC11443@gangnam.samsung> Content-transfer-encoding: 8bit In-reply-to: <20180105164958.csojn6vhy72bwoac@dtor-ws> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJKsWRmVeSWpSXmKPExsWy7bCmme7lwJAog7/HDCwW/3jOZHF40QtG i5ufvrFaXN41h83i/+9zrA6sHteXfGL22DnrLrvH8p0mHp83yQWwRKXaZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCtVVIoS8wpBQoFJBYXK+nb2RTl l5akKmTkF5fYKkUbGhrpGRqY6xkZGemZGMdaGZkClSSkZhzub2UsOMZR0XD+DGsD4xu2LkYO DgkBE4nHhxi7GLk4hAR2MEq8Wf+ZBcL5zihx8XonUxcjJ1jRjF+P2CESGxglTu5eyA6S4BUQ lPgx+R4LiM0sIC3x6O8MdghbU+LFl0lgcSGBT4wSH9osQGwWAVWJpwdawIayAdU03f7BBmKL COhLbJ/9C+wMZoEuRomm5bPABgkLOEgcmj2bCWKZicTWQ31Qy+QlDl55DmZzCphJrJo3Aaxe VEBZYsGrKWCXSgjsYZN4PfUUC8QLLhJXX3xhhLCFJV4d38IOYUtLPFu1ESrezCix7XYyRPME RolPe79C/W8s8WxhFxPEZj6JjsN/2SGBxyvR0SYEUeIh8aDjG9RMR4nZPc+ZIcH1hFFi8o6X jBMY5WYhhdgspBCbhRRis5A8t4CRZRWjWGpBcW56arFRgbFecWJucWleul5yfu4mRnCy03Lf wbjtnM8hRgEORiUeXonW4Cgh1sSy4srcQ4wSHMxKIry+84FCvCmJlVWpRfnxRaU5qcWHGE2B MTGRWUo0OR+YiPNK4g1NLA1MzMyMzM0sgMlNnLc1wCVKSCA9sSQ1OzW1ILUIpo+Jg1OqgZHl 996LgTvfxRzfwCgSaFx1TLF0jZqgmnxDzBHr0sOu2ctm+01oK/wgKneIha8odM6yleGr2t54 iyRyeP9777Qm4avJCdmjPf1uPx9M/eGTt+uOR/TjV8EqTgYPrk3oCn9V9ez2E/MF+1Tn/OJa qhgn0enU9SX1z2atdzfyZFcsL9nTxff3yjUlluKMREMt5qLiRAAOsn5AjAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsVy+t9jQd3LgSFRBsduK1ss/vGcyeLwoheM Fjc/fWO1uLxrDpvF/9/nWB1YPa4v+cTssXPWXXaP5TtNPD5vkgtgieKySUnNySxLLdK3S+DK ONzfylhwjKOi4fwZ1gbGN2xdjJwcEgImEjN+PWLvYuTiEBJYxyhxadE5sASvgKDEj8n3WEBs ZgFpiUd/ZwAVcQDZ6hJTpuRC1H9ilDiz7Rg7SA2LgKrE0wMtTCA2m4CmRNPtH2BzRAT0JbbP /sUI0sAs0MUosXjmPbCEsICDxKHZs5kglplIbD3UxwIx9RmjxPs/S1ghNstLHLzyHOwKTgEz iVXzJoBtExVQlljwagr7BEaBWUiOnYXk2FkIx85CMmkBI8sqRsnUguLc9NxiowKjvNRyveLE 3OLSvHS95PzcTYzAMN92WKt/B+PjJfGHGAU4GJV4eCVag6OEWBPLiitzDzFKcDArifD6zgcK 8aYkVlalFuXHF5XmpBYfYpTmYFES5+XPPxYpJJCeWJKanZpakFoEk2Xi4JRqYFT1eVGhK9ed 9OzfDDmxCSeYSmfmyFQFpb+2Yb1ToL/01DvD/3bKK190PmdI5Dur8yF9YtbVPdMnz0meGndn 9/Z4B4c9uuutDl/oneQqdvSwx4LvD6/F9NywPzUxODS+/1DN35vWrzliNl0IeFj+ZPI/gTjR a9vj5VVVEjPPfzbWSxZ35PAW3qDEUpyRaKjFXFScCAD8VrhzbwIAAA== X-CMS-MailID: 20180109052331epcas2p45b647997895607abcc623c9b1b60c764 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171212074156epcas2p4fefff65c3316ec1aa9b3d7797aaca550 X-RootMTR: 20171212074156epcas2p4fefff65c3316ec1aa9b3d7797aaca550 References: <20171212074149.7844-1-andi.shyti@samsung.com> <20180105095715.GA6679@gangnam.samsung> <20180105164958.csojn6vhy72bwoac@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Dmitry, On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote: > Hi Andi, > > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > this is a kind ping, would you also mind giving me a feedback to > > Yes, sorry. Could you please split the patch for each driver > individually? Also, until we have an update to the CodingStyle doc > mandating the C++ style comments, I'd prefer keeping the original style > of comments. So // for the SPDX line and /* */ for the rest. I was actually following Linus guideline [1] [2]. I also had the same discussion previously in another context [3]. Please let me know if you still want a mixed style of comments in the next patch. Thanks, Andi [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 [2] https://marc.info/?l=linux-kernel&m=150964359922353 [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2