From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbeAIJaU (ORCPT + 1 other); Tue, 9 Jan 2018 04:30:20 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:34498 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbeAIJ2B (ORCPT ); Tue, 9 Jan 2018 04:28:01 -0500 Date: Tue, 9 Jan 2018 12:26:16 +0300 From: Dan Carpenter To: Srinivas Kandagatla , Sagar Dharia Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 1/2] slimbus: qcom-ctrl: fix a NULL test Message-ID: <20180109092616.mfha2rs56oaxfjaz@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=846 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801090133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: "retries" ends when it is set to -1 and not 0 so that part of the test is wrong. This bug would lead to a NULL dereference a couple lines later. Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Dan Carpenter --- Should Greg be added to the MAINTAINERS file for this driver? diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index fb1a5e0eb8dd..3ab59209cbdc 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -345,7 +345,7 @@ static int qcom_xfer_msg(struct slim_controller *sctrl, } } - if (!retries && !pbuf) + if (!pbuf) return -ENOMEM; puc = (u8 *)pbuf;