From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbeAIJey (ORCPT + 1 other); Tue, 9 Jan 2018 04:34:54 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:53262 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbeAIJew (ORCPT ); Tue, 9 Jan 2018 04:34:52 -0500 Date: Tue, 9 Jan 2018 12:34:35 +0300 From: Dan Carpenter To: Srinivas Kandagatla , Sagar Dharia Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH] slimbus: Unlock on error path in slim_msg_response() Message-ID: <20180109093435.4n45kxibmpvpb5i2@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=520 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801090134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: We need to unlock and restore IRQs before returning on this error path. Fixes afbdcc7c384b0 ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Dan Carpenter diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a4c75e..94818a8427e2 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -36,6 +36,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) msg = txn->msg; if (msg == NULL || msg->rbuf == NULL) { + spin_unlock_irqrestore(&ctrl->txn_lock, flags); dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n", tid, len); return;