From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933473AbeAIPi1 (ORCPT + 1 other); Tue, 9 Jan 2018 10:38:27 -0500 Received: from mr11p00im-asmtp003.me.com ([17.110.69.254]:63629 "EHLO mr11p00im-asmtp003.me.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933342AbeAIPiZ (ORCPT ); Tue, 9 Jan 2018 10:38:25 -0500 X-Greylist: delayed 3615 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Jan 2018 10:38:25 EST X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-09_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1801090207 From: Xiongwei Song To: linux@armlinux.org.uk, rafael.j.wysocki@intel.com, ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sxwjean@gmail.com Subject: [PATCH] ARM: locomo: fix free dev incorrectly Date: Tue, 09 Jan 2018 22:37:55 +0800 Message-id: <20180109143755.16931-1-sxwjean@me.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: In function locomo_init_one_child, If kzalloc call is failed for dev we would goto out label, then call kfree for dev, however, dev is NULL, we shouldn't do this. Signed-off-by: Xiongwei Song --- arch/arm/common/locomo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c index 51936bde1eb2..fb21b5ade391 100644 --- a/arch/arm/common/locomo.c +++ b/arch/arm/common/locomo.c @@ -256,10 +256,9 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info) NO_IRQ : lchip->irq_base + info->irq[0]; ret = device_register(&dev->dev); - if (ret) { - out: + if (ret) kfree(dev); - } + out: return ret; } -- 2.15.1