mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Harsh Shandilya <msfjarvis@gmail.com>
Cc: devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
	linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
	"Harsh Shandilya" <harsh@prjkt.io>,
	"Martijn Coenen" <maco@android.com>
Subject: Re: [PATCH 2/2] drivers: android: Fix logtags in methods
Date: Tue, 9 Jan 2018 18:02:14 +0100	[thread overview]
Message-ID: <20180109170214.GA16149@kroah.com> (raw)
In-Reply-To: <20171222140703.21235-2-msfjarvis@gmail.com>

On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote:
> From: Harsh Shandilya <harsh@prjkt.io>
> 
> Several methods in the driver were hardcoding
> the function name in their logging calls which
> is a checkpatch violation. Utilise the __func__
> macro to avoid needing to add the function name
> as is to the string.
> 
> Test: logtags in dmesg remain unaffected before
> and after the patch.
> 
> Signed-off-by: Harsh Shandilya <harsh@prjkt.io>
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Arve Hjønnevåg" <arve@android.com>
> Cc: Todd Kjos <tkjos@android.com>
> Cc: Martijn Coenen <maco@android.com>
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/android/binder.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Patch does not apply to my tree :(

  reply	other threads:[~2018-01-09 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 14:07 [PATCH 1/2] drivers: android: Use octal permissions Harsh Shandilya
2017-12-22 14:07 ` [PATCH 2/2] drivers: android: Fix logtags in methods Harsh Shandilya
2018-01-09 17:02   ` Greg Kroah-Hartman [this message]
2018-01-09 19:45     ` Harsh Shandilya
2018-01-09 20:03       ` Greg Kroah-Hartman
2018-01-09 20:07         ` Harsh Shandilya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109170214.GA16149@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=harsh@prjkt.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=msfjarvis@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome