From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: Missing watchdog after ACPI watchdog creation failure
Date: Wed, 10 Jan 2018 17:23:43 +0200 [thread overview]
Message-ID: <20180110152343.GO27654@lahna.fi.intel.com> (raw)
In-Reply-To: <s5hd12h21cg.wl-tiwai@suse.de>
On Wed, Jan 10, 2018 at 04:13:51PM +0100, Takashi Iwai wrote:
> Hi,
>
> on the recent kernels, i2c-i801 skips the creation of iTCO wdt when
> ACPI WDAT is present. It's fine when ACPI really creates the watchdog
> device. But, we've got a report showing that the watchdog is missing
> on some machines because ACPI failed to create, and yet i2c-i801 still
> skips because acpi_has_watchdog() returns true.
>
> More specifically, the machine gets an error from acpi_watchdog.c
> like:
> platform wdat_wdt: failed to claim resource 3: [io 0x040a-0x040c]
> ACPI: watchdog: Device creation failed: -16
>
> where the region was registered by pnp,
> % cat /proc/ioports
> ....
> 0400-047f : pnp 00:01
>
>
> One may say that BIOS sucks, but OTOH, the complete lack of watchdog
> thereafter can be seen as a regression, too. It used to work on the
> older kernel as iTCO wdt was provided by i2c-i801.
Hmm, if the resource is already taken I wonder how iTCO can work? Are
you sure iTCO works on those systems?
> Shouldn't acpi_has_watchdog() rather checks whether the watchdog
> device creation succeeded or not?
Yes, or rather we should first figure out what the actual problem is ;-)
Are you able to get acpidump from that system with full dmesg?
next parent reply other threads:[~2018-01-10 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s5hd12h21cg.wl-tiwai@suse.de>
2018-01-10 15:23 ` Mika Westerberg [this message]
2018-01-10 15:43 ` Takashi Iwai
2018-01-17 11:53 ` Takashi Iwai
2018-01-18 10:20 ` Mika Westerberg
2018-01-18 11:26 ` Mika Westerberg
2018-01-18 11:28 ` Takashi Iwai
2018-02-13 9:38 ` Takashi Iwai
2018-01-18 19:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110152343.GO27654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®