From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966057AbeAJQWs (ORCPT + 1 other); Wed, 10 Jan 2018 11:22:48 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:57232 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965909AbeAJQWp (ORCPT ); Wed, 10 Jan 2018 11:22:45 -0500 From: Arnd Bergmann To: Vladimir Zapolskiy , Sylvain Lemieux Cc: Arnd Bergmann , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: lpc3250: fix uda1380 gpio numbers Date: Wed, 10 Jan 2018 17:22:00 +0100 Message-Id: <20180110162220.224945-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:XL6nn3E9bLVTcjoo67Q6rfPUECqoWqnR+0pPXOieuFZLOe0F+/P bQP8EkNKrQqEPAEo/F5AAcvDC3UcjSDbetuP56GM5JPRUIwwFt6xndVLkHt8qoTbYFlXXgk IHr3Sbc4JkDgk1wPwRjajUDYNmSyeUCBFThBN3Y2MqtFrM11B6n4rjjw1/lWIO4QZhvXotu RSynj5k2fh/NRVKxZfV+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:0QfRX3aqUNE=:PDlFcW1eEYmLfyUP+aoFYj np5i75SdYPh9i9te7JX5SoLI7mSHJBc5NdL2MXBWl5e5slOEz/gSZTwnX8Z2sbSSUvAo8dY9z 2U8Fz9cHOgMC5HjvREyGtKthUj4dLQ8eEkvEDPX+cxg/qo4LCjT8wZMUPT7gxYQxqmwTEyMkS jMmxHpmCf65vCA2tMmVYUYtV6YJ93qU7UuAC/Ze2PCF2besN+e5GDfTDc4BxVgebnNZPl2sVO Se8iTaIN/LkPKJwmdJePhqAHC4ltFvRxjUA0bA9kbMDhE9oU/JZQNiAVvA4CF8GdWt5hesONF yODAx5PfCpkkeNDg6Xg2FP3RrEcluC8xQEe+s6hj4o24WfTIKpShb3totJFtfyA2CDiH+t25h 4ma+WAPRTUolsK89107aaA79++/6L1sVMFoq2XPZLJ+xESH8GTsEh8u/uDXAeXh1cj88nR0EM VK1unJo5BR0fNO8i+lMFtPyxiZJPmgNfMpyOmGWjCDi+HFT1qvHYwgJ52MeuVe54SoPG/W2mt VRVHZDp19oposJTAZG1VQu9IVgxAUplId1+e1o+nRS3c/DHDkvTVCIg845aOXmN7NuNn/6s53 SFyHAV/PfwU0RVtQUs0nbY2ST7tU/ppo+7pNBt+o7BMWWsXYfFNnHWBrX0Qij+nt7FNPZlCrG 3l2oyeL5Irmm3d8VdoLxHufvO0Wt5sTA9ke48aGE0dX1UAT8B/YoV74aTstEfPzXs5Rgn4GZf a6RLe1RCsdcQtYCSpzvIFbq8BVP44CijVuiUlA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: dtc warns about obviously incorrect GPIO numbers for the audio codec on both lpc32xx boards: arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 It looks like the nodes are written for a different binding that combines the GPIO number into a single number rather than a bank/number pair. I found the right numbers on stackexchange.com, so this patch fixes the warning and has a reasonable chance of getting things to actually work. Link: https://unix.stackexchange.com/questions/59497/alsa-asoc-how-to-correctly-load-devices-drivers/62217#62217 Signed-off-by: Arnd Bergmann --- arch/arm/boot/dts/lpc3250-ea3250.dts | 4 ++-- arch/arm/boot/dts/lpc3250-phy3250.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/lpc3250-ea3250.dts b/arch/arm/boot/dts/lpc3250-ea3250.dts index c43adb7b4d7c..58ea0a4e7afa 100644 --- a/arch/arm/boot/dts/lpc3250-ea3250.dts +++ b/arch/arm/boot/dts/lpc3250-ea3250.dts @@ -156,8 +156,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; }; diff --git a/arch/arm/boot/dts/lpc3250-phy3250.dts b/arch/arm/boot/dts/lpc3250-phy3250.dts index c72eb9845603..1e1c2f517a82 100644 --- a/arch/arm/boot/dts/lpc3250-phy3250.dts +++ b/arch/arm/boot/dts/lpc3250-phy3250.dts @@ -81,8 +81,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; }; -- 2.9.0