mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Paul Burton <paul.burton@mips.com>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Cc: Jesse Chan <jc@linux.com>, Arnd Bergmann <arnd@arndb.de>,
	Matt Redfearn <matt.redfearn@mips.com>,
	Dengcheng Zhu <dengcheng.zhu@mips.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] auxdisplay: img-ascii-lcd: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE
Date: Wed, 10 Jan 2018 17:41:10 +0100	[thread overview]
Message-ID: <20180110164127.885061-1-arnd@arndb.de> (raw)

From: Jesse Chan <jc@linux.com>

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
see include/linux/module.h for more information

This adds the license as "GPL", which matches the header of the file.

MODULE_DESCRIPTION and MODULE_AUTHOR are also added.

Signed-off-by: Jesse Chan <jc@linux.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Jesse sent this patch a while ago, but nobody picked it up so far.

Greg, could you merge this through the char-misc tree?

 drivers/auxdisplay/img-ascii-lcd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index db040b378224..9180b9bd5821 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -441,3 +441,7 @@ static struct platform_driver img_ascii_lcd_driver = {
 	.remove	= img_ascii_lcd_remove,
 };
 module_platform_driver(img_ascii_lcd_driver);
+
+MODULE_DESCRIPTION("Imagination Technologies ASCII LCD Display");
+MODULE_AUTHOR("Paul Burton <paul.burton@mips.com>");
+MODULE_LICENSE("GPL");
-- 
2.9.0

             reply	other threads:[~2018-01-10 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 16:41 Arnd Bergmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-20 20:53 Jesse Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110164127.885061-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=dengcheng.zhu@mips.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jc@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.redfearn@mips.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=paul.burton@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®