From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753144AbeAJSln (ORCPT + 1 other); Wed, 10 Jan 2018 13:41:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:57620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbeAJSlm (ORCPT ); Wed, 10 Jan 2018 13:41:42 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0B6220834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Wed, 10 Jan 2018 10:41:41 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH] f2fs: fix to cover f2fs_fiemap with inode_lock Message-ID: <20180110184141.GA18352@jaegeuk-macbookpro.roam.corp.google.com> References: <20180110061806.15744-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110061806.15744-1-yuchao0@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/10, Chao Yu wrote: > This patch fix to cover f2fs_fiemap with inode_lock in order to make > the whole interface avoiding race with mapping change. > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index d6302051a65d..330085d3adfc 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1146,18 +1146,18 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > u32 flags = 0; > int ret = 0; > > + inode_lock(inode); > + > ret = fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC); > if (ret) > - return ret; > + goto out; Uh? We don't need to cover fiemap_check_flags() by inode_lock(). > > if (f2fs_has_inline_data(inode)) { > ret = f2fs_inline_data_fiemap(inode, fieinfo, start, len); > if (ret != -EAGAIN) > - return ret; > + goto out; > } > > - inode_lock(inode); > - > if (logical_to_blk(inode, len) == 0) > len = blk_to_logical(inode, 1); > > -- > 2.15.0.55.gc2ece9dc4de6