From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933596AbeAKORR (ORCPT + 1 other); Thu, 11 Jan 2018 09:17:17 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47446 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932973AbeAKORP (ORCPT ); Thu, 11 Jan 2018 09:17:15 -0500 From: Thomas Richter To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org Cc: brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Thomas Richter Subject: [PATCH] perf trace: Warn about --call-graph dwarf invalid parameters Date: Thu, 11 Jan 2018 15:16:57 +0100 X-Mailer: git-send-email 2.13.5 X-TM-AS-GCONF: 00 x-cbid: 18011114-0040-0000-0000-00000423A435 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011114-0041-0000-0000-000020C701D8 Message-Id: <20180111141657.14000-1-tmricht@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-11_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801110198 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: When invoking ./perf trace --call-graph fp|lbr with additional parameters a warning is printed that these additional comma separated parameters are silently ignored. [root@f27 perf]# ./perf trace -vv --no-syscalls --call-graph lbr,1024 callchain: No more arguments needed for --call-graph lbr [root@f27 perf]# This does not happen for --call-graph dwarf,4096,4. The additional parameter 4 is silently ignored and no warning printed. Before: [root@f27 perf]# ./perf trace --no-syscalls --call-graph dwarf,4096,4 Please specify something to trace. [root@f27 perf]# After: [root@s35lp76 perf]# ./perf trace --no-syscalls --call-graph dwarf,4096,4 callchain: No more arguments needed for --call-graph dwarf[,xxx] Please specify something to trace. [root@s35lp76 perf]# Signed-off-by: Thomas Richter --- tools/perf/util/callchain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 082505d08d72..59292d582894 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util/callchain.c @@ -272,6 +272,10 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) ret = get_stack_size(tok, &size); param->dump_size = size; + if (strtok_r(NULL, ",", &saveptr)) { + pr_err("callchain: No more arguments " + "needed for --call-graph dwarf[,xxx]\n"); + } } } else if (!strncmp(name, "lbr", sizeof("lbr"))) { if (!strtok_r(NULL, ",", &saveptr)) { -- 2.13.4