From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbeAKXDW (ORCPT + 1 other); Thu, 11 Jan 2018 18:03:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49294 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbeAKXDV (ORCPT ); Thu, 11 Jan 2018 18:03:21 -0500 Date: Thu, 11 Jan 2018 15:03:19 -0800 From: Andrew Morton To: Joe Perches Cc: LKML , Greg KH Subject: Re: checkpatch: exclude drivers/staging from if with unnecessary parentheses test Message-Id: <20180111150319.86ca6ee1c16b85e4c0e034a0@linux-foundation.org> In-Reply-To: <1515704034.9619.165.camel@perches.com> References: <1515704034.9619.165.camel@perches.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, 11 Jan 2018 12:53:54 -0800 Joe Perches wrote: > Greg KH doesn't like this test so exclude the staging directory > from the implied --strict only test unless --strict is actually > used on the command-line. > "doesn't like" is rather vague. What is the objection, specifically? Also, an example of code which has an "if with unnecessary parentheses" would help others understand the decision.