From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934978AbeAKQoc (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 11:44:32 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:51525 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933231AbeAKQob (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 11:44:31 -0500
Date: Thu, 11 Jan 2018 17:44:24 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Kees Cook <keescook@google.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Jiri Kosina <jikos@kernel.org>, gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Message-ID: <20180111164424.GN3040@hirez.programming.kicks-ass.net>
References: <cover.1515635197.git.jpoimboe@redhat.com>
 <a181ea89cc196187b85867cb5eb13707279a887a.1515635197.git.jpoimboe@redhat.com>
 <1515688058.22302.366.camel@infradead.org>
 <20180111163326.deqtbqt72avfweup@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180111163326.deqtbqt72avfweup@treble>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Jan 11, 2018 at 10:33:26AM -0600, Josh Poimboeuf wrote:
> On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote:
> > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote:
> > > 
> > > +#define ANNOTATE_NOSPEC_ALTERNATIVE                            \
> > > +       "999:\n\t"                                              \
> > > +       ".pushsection .discard.nospec\n\t"                      \
> > > +       ".long 999b - .\n\t"                                    \
> > > +       ".popsection\n\t"
> > > +
> > 
> > <mode name="peterz">
> >   Ick, numbers. Use .Lfoo_%= instead.
> > </mode>
> 
> I seem to recall that not working with inline asm, maybe old versions of
> GCC don't like it or something?  I can try it and see if 0-day bot
> complains.

Note that we'll raise the GCC limit to 4.5 soon to mandate asm-goto, for
x86 at least.