From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934294AbeAKRhs (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 12:37:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33382 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932459AbeAKRhr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 12:37:47 -0500
Date: Thu, 11 Jan 2018 11:37:44 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Kees Cook <keescook@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Jiri Kosina <jikos@kernel.org>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Message-ID: <20180111173744.2iysfjky7hbjozqf@treble>
References: <cover.1515635197.git.jpoimboe@redhat.com>
 <a181ea89cc196187b85867cb5eb13707279a887a.1515635197.git.jpoimboe@redhat.com>
 <1515688058.22302.366.camel@infradead.org>
 <CA+55aFzLA2dBhVTsvEBZ58aS2Jgp020cPC3MvMR_RuJqFmM67Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CA+55aFzLA2dBhVTsvEBZ58aS2Jgp020cPC3MvMR_RuJqFmM67Q@mail.gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 11 Jan 2018 17:37:47 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Jan 11, 2018 at 09:29:48AM -0800, Linus Torvalds wrote:
> That, btw, is also why it's pointless to make the small numbers
> "bigger". Using "1122" as a label is actively worse than just using
> "1".
> 
> You shouldn't try to fool yourself and think that your number is
> "unique". It doesn't need to be. A label needs to be unique within one
> use, and the use just tells _which_ of the non-unique numbers you use.
> 
> And yes, you could even re-use the number within one macro or inline
> asm. But that's just confusing. Make the number unique for the
> particular macro or inline use.

What if the macro is used by another macro which needs to jump across
it?  If the labels conflict then the outer macro will accidentally jump
to the inner macro.

-- 
Josh