From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754632AbeALI2d (ORCPT + 1 other); Fri, 12 Jan 2018 03:28:33 -0500 Received: from mout01.posteo.de ([185.67.36.65]:41542 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754364AbeALI2b (ORCPT ); Fri, 12 Jan 2018 03:28:31 -0500 From: Max Schulze To: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Max Schulze Subject: [PATCH v2] USB: serial: option: add id for Motorola Solutions TETRA PEI Date: Fri, 12 Jan 2018 09:27:15 +0100 Message-Id: <20180112082715.5451-1-max.schulze@posteo.de> X-Mailer: git-send-email 2.15.1 Autocrypt: addr=max.schulze@posteo.de; keydata=xsFNBFZwMSMBEACvfjS9OuLRpIRt31AjZQex0c3TRiOeDMwT2HLtcROSr3yjYV4OLILrbtBJ07/yyEAGgK81HfJmFc5OEH8KgsMV+4qZ0xpl5lU3b5iqQM5TpV43Mlj0Btnm1nwt6SEP386VXNXLU50zGmf+xSYW44v62nZ6O6+BzgDlm1WDfHOgPbqnlTj0hnGhIaxWWHQfmxj4LJHgqq52p0UN9rKBgL60eSwCqpXPB5IaxqmL2SA7Un8vP1EXVCDNMvnrtNMJ2oaCqEITloIfuGRyeakmc+gZTpmEFA+wdoAK1iYKrJ/GWcBIsGW8NgMKgn6O5sP4slE2uNbv/pjORqelYMp50O9cWH3Kdoej2Iniho1nhhXD7/4lJtbYRLDxbq1De+/Mc+8S5EVTwjHbK2mOGlYxRSWqBkx6zLH5bj6fw42ITM8uZx/+earYC50vGqokiuAP10vlndtdhWkGkxcMFroFs/jpq3noa7ng/9QYpwqFV/KRfu0O2410H4zEpp7h4UHf2NxjTCumaDRTWoWE1GtH13D9Zr7w8A6iNSyL55/3Bc4xNlVVpqxYJAQR4qFYvQcP/Ox3eIpqUGMcCwp+6sx1v3O+DNJXZlXL6eolGPExODW6gaB1ndE+qfwMAfVC/vSIYkCS0E1rF/gk/kjSxnxImQ3xmyOQBFJl+sztgiHI44ny+wARAQABzS1tYXguc2NodWx6ZUBwb3N0ZW8uZGUgPG1heC5zY2h1bHplQHBvc3Rlby5kZT7CwXgEEwECACIFAlZwMSMCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELOK1wf5Jjx40g0P/jJpD+9jJUweaOfT92kMPW9yA6/aRZuhQ2ouNESU5LD+QOlqRiLvpIYSyzu+PhKapvaQ18Z2shvA6hSVWBdGXgCwjormrvwms6l1Ldyuoar AWDvalvUSQZXim2/B6ZUoLC7GtHDFYRreszdhG3GfGIsZ06cK5X2Z9F7Fyz9ExL7qDcgiB0KLnMn19NvUeH21xmcmp50lMwdTWgjgj4VYfSpviPsFexeKYo3aDumC1I0WlVjzkC7Yz7U51gK7Xkms0/FurmWu+o2hDFBvfnL5NXQfPpvc5uDup2ViwKDxo0k/rCXqAN8sm5bTGh+QF2GRZjp3LNzPzH8yPMwpWAg+maMyjfbIVF95iB5WoZcYM7rDqZ5MV8yEZ3qkybXxnoe3X1Bs1naDMSGzbiUVoiO+9jdRgKfjC4GjVdHZ0ExNCzLuOICJbxa8McJPsg7lXaDJSiqwy0uIaTxMGHG2xSnw8FcR6cvgfi9knBktSV7v2BFARd/diZAT3bSjdwc7dIH8r9LWznvSExaDDQ07EEeM3uTZKlp9V7hbxQPhK98zVBwol37CPP6rOV2e5vXRA43wZG961xCK1HuJQtTDh92I7HiFChD/ApDWZ5TjTJdE6iIGhASiCYb4DG6IFyf8tcG55nWLjisfA7wkzP9yv3JP/20e72emhtfRwlOLZaeH2K2tzsFNBFZwMSMBEADIbYYq7ZoaRlLlhmIutwfdM91p+lctKfaXBgtMcB2l6oMh2AXioG3RJGd6t8/k5w4VsHcB6wN42fRKzqQxrc5V/ptr1LDQYxctVn31YB8zXjM5Ml7DEZXGoG3g+shryJsgX4tkot2r8r3zLXjrxSU0JaRgikSvdMxUVjRagG6aiUlr+piUqc8g/Ca5m7iZkNdlBvMPGh29F4UtHLfI1AmwoxlVUppwm4udXt8EZvGdjF8ce5uREFf9bVBhkgIHoWCOyFIjqjJECZSjB50xZ3bDg90u6QCPDOj3dH2EqNQS17sO19WR+xcoPhkMQ+gLYqts/hAte4S7j6Iy/mG33Kb6E78S0eEyLPEMJpzl3tCRcxHN5k+nYcbBuSoSd6qkwqb79KM8JZ8DHxoFTjTPZBqp PG3/y/jdUYp17RHM+AY/GFoDmE7VSBEVCRzCVHVGzZtYJgSIurEAyqOAf1JgqQc2hjhdmJBZrkzC3nuoTm/pBWO+kpwa7+BysxVLAF/sCQdm4gMGPmgPBDBdVIbSvKq3bBLqHyaMjILIbdVPwBtEX6+64SbP9QYbXxH0oBAXj3sHEnMQm97yDMEHmxZKGCdNjKszZqtLNHG4K3zhD1DAu0QUlyftzYnqIk5JcGGJIuIIbfkT+edon5VE7QdnQgWSNatzUnnj9ZvppiVphtAfWwARAQABwsFfBBgBAgAJBQJWcDEjAhsMAAoJELOK1wf5Jjx49KQP/AtPaNQwIp+ZFUTpvgAh12PdlBfjDL4KGFSpP6zY6M+ouI9tIPFEdGAreVMVd+8+K04coYI3P9sOctLHkrbKDYmtDhgbS8aRK6qimb1/ynBv3h4exfVvfvYI5o9YhevdB8Ow1nAwdyEkpLKy0tM8CPLcuUe+CjpJffb6s7cW21x4yclrfpviQeH1vaI6GJiu+cAfj5i052/r26R84mRWzFiS3NisFTnQ51qg/tbyp6rDml50K8EcC1iVdbhZtKDVhiOtl+1tVa6esS8USlDFmahNxAv8X84ZPavxq0XDU0J3oydWMYojgY5wbjzyK8yP7ylo49d52J31F3810r2B11U/5MjZHMrxPGwWH43OofIkL3EbviHpXCnf9SYQX5JRcUgEpxQdg+ciaDuMGzM9sCLA+nC6X+tIvPTSyZ+tvpRTWetUpYuDdsKtGIbeGWfJNWc2HXu+FR81uLrfRep65CzD387b0QZFbv2a9jgdBQ4vVLgcLF91P6VreKPgkFS0bzTNBji70PTJM+sjTgSPzsjv1VJUVzKOEM6fQ0eJIx+6SVoVOURJPG5bdMI4XwN3GG5tYbCxKtLG62Jkha4rxKmY4Kaf+jbQuAhjqmJiTgICE7VgUapjAgWpjf0OX+SsOF8rVfQYjIYgXKQRhH/1FYKaWmLNa +TnsDNfJtsvPDU4 OpenPGP: url=https://posteo.de/keys/max.schulze@posteo.de.asc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Add Motorola Device ID and blacklist entry to the driver usb/serial/option Signed-off-by: Max Schulze --- v2: reformatted Patch, first version was declined by GK-H's Bot Thanks for the help, Johan! To an URB setup request from the host bmRequestType: 0x21 bRequest: 34 wValue: 0x0003 wIndex: 0 (0x0000) wLength: 0 the device responds with URB status: Broken pipe (-EPIPE) (-32) So blacklisting to avoid the usb_wwan_send_setup in usb_wwan_dtr_rts of usb_wwan. Tested now to work with miniterm.py and minicom without errors. D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=0cad ProdID=9011 Rev=24.16 S: Manufacturer=Motorola Solutions Inc. S: Product=Motorola Solutions TETRA PEI interface C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) drivers/usb/serial/option.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index b6320e3be429..c8819a41d2df 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -686,6 +686,10 @@ static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { .reserved = BIT(1) | BIT(4), }; +static const struct option_blacklist_info motorola_pei_blacklist = { + .sendsetup = BIT(0) | BIT(1), +}; + static const struct usb_device_id option_ids[] = { { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) }, { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) }, @@ -2054,6 +2058,8 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ + { USB_DEVICE(0x0cad, 0x9011), /* Motorola Solutions TETRA PEI */ + .driver_info = (kernel_ulong_t)&motorola_pei_blacklist }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids); -- 2.15.1