From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965049AbeALRur (ORCPT + 1 other); Fri, 12 Jan 2018 12:50:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:47680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbeALRuq (ORCPT ); Fri, 12 Jan 2018 12:50:46 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9554C21746 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 12 Jan 2018 12:50:42 -0500 From: Steven Rostedt To: Jessica Yu Cc: Namit Gupta , mingo@redhat.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com, a.sahrawat@samsung.com Subject: Re: [PATCH v3] ftrace/module: Move ftrace_release_mod() to ddebug_cleanup label Message-ID: <20180112125042.13f12111@gandalf.local.home> In-Reply-To: <20180112173224.junllgodqu3jgu42@redbean> References: <1515388281-7941-1-git-send-email-gupta.namit@samsung.com> <20180112173224.junllgodqu3jgu42@redbean> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, 12 Jan 2018 18:32:27 +0100 Jessica Yu wrote: > +++ Namit Gupta [08/01/18 10:41 +0530]: > >ftrace_module_init happen after dynamic_debug_setup, it is desired that > >cleanup should be called after this label however in current implementation > >it is called in free module label,ie:even though ftrace in not initialized, > >from so many fail case ftrace_release_mod() will be called and unnecessary > >traverse the whole list. > >In below patch we moved ftrace_release_mod() from free_module label to > >ddebug_cleanup label. that is the best possible location, other solution > >is to make new label to ftrace_release_mod() but since ftrace_module_init() > >is not return with minimum changes it should be in ddebug_cleanup label. > > > >Signed-off-by: Namit Gupta > > Hi Steven, > > Could I get an ACK for this patch? > Hi Jessica, Thanks for asking, because this came in while I was traveling and is buried in the "travel log" part of my inbox. Please add: Reviewed-by: Steven Rostedt (VMware) -- Steve