From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964952AbeALQs2 (ORCPT + 1 other); Fri, 12 Jan 2018 11:48:28 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48228 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964828AbeALQsZ (ORCPT ); Fri, 12 Jan 2018 11:48:25 -0500 Date: Fri, 12 Jan 2018 08:47:38 -0800 From: "Darrick J. Wong" To: Colin King Cc: linux-xfs@vger.kernel.org, Brian Foster , Dave Chinner , Eric Sandeen , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][xfs-next] xfs: fix check on struct_version for versions 4 or greater Message-ID: <20180112164738.GW5602@magnolia> References: <20180112163715.27169-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180112163715.27169-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8772 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=943 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801120229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 12, 2018 at 04:37:15PM +0000, Colin King wrote: > From: Colin Ian King > > It appears that the check for versions 4 or more is incorrect and is > off-by-one. Fix this. > > Detected by CoverityScan, CID#1463775 ("Logically dead code") > > Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function") > Signed-off-by: Colin Ian King Looks ok, Reviewed-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_sb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c > index 35b005d66977..869a2f3f0375 100644 > --- a/fs/xfs/libxfs/xfs_sb.c > +++ b/fs/xfs/libxfs/xfs_sb.c > @@ -951,7 +951,7 @@ xfs_fs_geometry( > geo->rtsectsize = sbp->sb_blocksize; > geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp); > > - if (struct_version < 3) > + if (struct_version < 4) > return 0; > > if (xfs_sb_version_haslogv2(sbp)) > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html