From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965140AbeALRcb (ORCPT + 1 other); Fri, 12 Jan 2018 12:32:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:45710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964892AbeALRc3 (ORCPT ); Fri, 12 Jan 2018 12:32:29 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8A5D2173D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jeyu@kernel.org Date: Fri, 12 Jan 2018 18:32:27 +0100 From: Jessica Yu To: rostedt@goodmis.org, Namit Gupta Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com, a.sahrawat@samsung.com Subject: Re: [PATCH v3] ftrace/module: Move ftrace_release_mod() to ddebug_cleanup label Message-ID: <20180112173224.junllgodqu3jgu42@redbean> References: <1515388281-7941-1-git-send-email-gupta.namit@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1515388281-7941-1-git-send-email-gupta.namit@samsung.com> X-OS: Linux redbean 4.14.11-200.fc26.x86_64 x86_64 User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: +++ Namit Gupta [08/01/18 10:41 +0530]: >ftrace_module_init happen after dynamic_debug_setup, it is desired that >cleanup should be called after this label however in current implementation >it is called in free module label,ie:even though ftrace in not initialized, >from so many fail case ftrace_release_mod() will be called and unnecessary >traverse the whole list. >In below patch we moved ftrace_release_mod() from free_module label to >ddebug_cleanup label. that is the best possible location, other solution >is to make new label to ftrace_release_mod() but since ftrace_module_init() >is not return with minimum changes it should be in ddebug_cleanup label. > >Signed-off-by: Namit Gupta Hi Steven, Could I get an ACK for this patch? Thanks! Jessica