From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752124AbeAOSJl (ORCPT + 1 other); Mon, 15 Jan 2018 13:09:41 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbeAOSJi (ORCPT ); Mon, 15 Jan 2018 13:09:38 -0500 Date: Mon, 15 Jan 2018 13:09:36 -0500 (EST) Message-Id: <20180115.130936.1345693036896474880.davem@davemloft.net> To: dima@arista.com Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com, arnd@arndb.de, dwindsor@gmail.com, edumazet@google.com, mingo@kernel.org, johannes.berg@intel.com, mark.rutland@arm.com, rrendec@arista.com, elena.reshetova@intel.com, netdev@vger.kernel.org Subject: Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names From: David Miller In-Reply-To: <20180109135535.15237-4-dima@arista.com> References: <20180109135535.15237-1-dima@arista.com> <20180109135535.15237-4-dima@arista.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jan 2018 10:09:37 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Dmitry Safonov Date: Tue, 9 Jan 2018 13:55:33 +0000 > +#define pf(flag) __stringify(flag), > +char *pkt_flag_names[] = { > + PKT_FLAGS > +}; > +#undef pf This should be static, also you don't use this table in this patch. You should add the table in the patch that actually uses the table.