From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbeAOE2m (ORCPT + 1 other); Sun, 14 Jan 2018 23:28:42 -0500 Received: from smtpbgau2.qq.com ([54.206.34.216]:38045 "EHLO smtpbgau2.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753540AbeAOE2l (ORCPT ); Sun, 14 Jan 2018 23:28:41 -0500 X-QQ-mid: bizesmtp4t1515990516t7uqfcbb0 X-QQ-SSF: 01400000004000F0FF42B00A0000000 X-QQ-FEAT: 2PHmmy4qbuLHo7MpK3hvdOhRbJoaYZ+L1pyyrYG4jVKqvVVuPAEYNSBbhPvGV F0nL8okjc3AEd1HcP7NsLKUT0tDN5CL2hvwXtkL0vN9ADEi6LX9CNoNnG1jIlJnf/JiIoq3 mlv9XimOt6EvAlr16aK/M2V5r5wEkgEasORmyHB2AUyaK9yiKZW2LyuRJB/LXVjIQXABi2q 6JthMxevSUCqw2nQ4qsLaNAHU6k+NUlgrjM1V3Rr+V+SGZ09PApkdo4Bo7l62r2AkAsfyVP EEmIzheEmco5vbz3Ej7OrCa3Q= X-QQ-GoodBg: 2 From: Yang Bo To: Thomas Gleixner Cc: Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Masami Hiramatsu , Mark Rutland , Andrew Morton , Laura Abbott , linux-kernel@vger.kernel.org, Yang Bo Subject: [PATCH] x86/kprobe: unbalanced preempt counter in kprobe_{fault,debug}_handler Date: Mon, 15 Jan 2018 12:28:28 +0800 Message-Id: <20180115042828.21004-1-yangbo@deepin.com> X-Mailer: git-send-email 2.15.1 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:deepin.com:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Don't see any preempt_disable() in do_debug() and do_page_fault(), there is no need to call preempt_enable_no_resched() here. Signed-off-by: Yang Bo --- arch/x86/kernel/kprobes/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index 1ea5c9caa8f1..6f2c43e33674 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -969,7 +969,6 @@ int kprobe_debug_handler(struct pt_regs *regs) } reset_current_kprobe(); out: - preempt_enable_no_resched(); /* * if somebody else is singlestepping across a probe point, flags @@ -1017,7 +1016,6 @@ int kprobe_fault_handler(struct pt_regs *regs, int trapnr) restore_previous_kprobe(kcb); else reset_current_kprobe(); - preempt_enable_no_resched(); } else if (kcb->kprobe_status == KPROBE_HIT_ACTIVE || kcb->kprobe_status == KPROBE_HIT_SSDONE) { /* -- 2.15.1