From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbeAOLyb (ORCPT + 1 other); Mon, 15 Jan 2018 06:54:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:56908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbeAOLya (ORCPT ); Mon, 15 Jan 2018 06:54:30 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20BFD2178D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 15 Jan 2018 06:54:27 -0500 From: Steven Rostedt To: Jiri Olsa Cc: Wang YanQing , acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/lib/traceevent/event-parse: delete pevent_register_function Message-ID: <20180115065427.5f947523@gandalf.local.home> In-Reply-To: <20180115100834.GC14646@krava> References: <20180115045014.GC20373@udknight> <20180115100834.GC14646@krava> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, 15 Jan 2018 11:08:34 +0100 Jiri Olsa wrote: > On Mon, Jan 15, 2018 at 12:50:14PM +0800, Wang YanQing wrote: > > After commit 4263cece22e3da94f16fbbcf71ce3807946d3ef3 > > ("perf tools: Stop reading the kallsyms data from perf.data"), > > there is no users of pevent_register_function in tree, so we > > could just delete it. > > > > I don't think you can remove this function, > perf is not the only user there Correct. The tools/lib does not have the same requirements as the kernel code. It's purpose is to be a library for other tools, not just what is in tree. Otherwise, I would be happy to add trace-cmd to the kernel proper, as that is where this code originated from. Don't delete those functions. They are required elsewhere. -- Steve