From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750995AbeAOTKw (ORCPT + 1 other); Mon, 15 Jan 2018 14:10:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:54436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbeAOTKv (ORCPT ); Mon, 15 Jan 2018 14:10:51 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E742021778 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 15 Jan 2018 14:10:49 -0500 From: Steven Rostedt To: Randy Dunlap Cc: LKML Subject: Re: [PATCH] tracing: prevent PROFILE_ALL_BRANCHES when FORTIFY_SOURCE=y Message-ID: <20180115141049.4b15876d@gandalf.local.home> In-Reply-To: <9199446b-a141-c0c3-9678-a3f9107f2750@infradead.org> References: <9199446b-a141-c0c3-9678-a3f9107f2750@infradead.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, 15 Jan 2018 11:07:27 -0800 Randy Dunlap wrote: > From: Randy Dunlap > > I regularly get 50 MB - 60 MB files during kernel randconfig builds. > These large files mostly contain (many repeats of; e.g., 124,594): > > In file included from ../include/linux/string.h:6:0, > from ../include/linux/uuid.h:20, > from ../include/linux/mod_devicetable.h:13, > from ../scripts/mod/devicetable-offsets.c:3: > ../include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static [enabled by default] > ______f = { \ > ^ > ../include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' > ^ > ../include/linux/string.h:425:2: note: in expansion of macro 'if' > if (p_size == (size_t)-1 && q_size == (size_t)-1) > ^ > > This only happens when CONFIG_FORTIFY_SOURCE=y and > CONFIG_PROFILE_ALL_BRANCHES=y, so prevent PROFILE_ALL_BRANCHES if > FORTIFY_SOURCE=y. > > Signed-off-by: Randy Dunlap > Acked-by: Steven Rostedt (VMware) I'm actually working on a patch that I need to send to Linus before 4.15 is released. Want me to add this one too? Or do you have your own branch to push to mainline with? -- Steve > --- > kernel/trace/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- orig/kernel/trace/Kconfig > +++ next/kernel/trace/Kconfig > @@ -355,7 +355,7 @@ config PROFILE_ANNOTATED_BRANCHES > on if you need to profile the system's use of these macros. > > config PROFILE_ALL_BRANCHES > - bool "Profile all if conditionals" > + bool "Profile all if conditionals" if !FORTIFY_SOURCE > select TRACE_BRANCH_PROFILING > help > This tracer profiles all branch conditions. Every if ()