From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: prevent PROFILE_ALL_BRANCHES when FORTIFY_SOURCE=y
Date: Mon, 15 Jan 2018 14:14:55 -0500 [thread overview]
Message-ID: <20180115141455.01cebe74@gandalf.local.home> (raw)
In-Reply-To: <45e4c153-a232-d953-9666-858c0436fd74@infradead.org>
On Mon, 15 Jan 2018 11:12:46 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 01/15/2018 11:10 AM, Steven Rostedt wrote:
> > On Mon, 15 Jan 2018 11:07:27 -0800
> > Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> I regularly get 50 MB - 60 MB files during kernel randconfig builds.
> >> These large files mostly contain (many repeats of; e.g., 124,594):
> >>
> >> In file included from ../include/linux/string.h:6:0,
> >> from ../include/linux/uuid.h:20,
> >> from ../include/linux/mod_devicetable.h:13,
> >> from ../scripts/mod/devicetable-offsets.c:3:
> >> ../include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static [enabled by default]
> >> ______f = { \
> >> ^
> >> ../include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
> >> ^
> >> ../include/linux/string.h:425:2: note: in expansion of macro 'if'
> >> if (p_size == (size_t)-1 && q_size == (size_t)-1)
> >> ^
> >>
> >> This only happens when CONFIG_FORTIFY_SOURCE=y and
> >> CONFIG_PROFILE_ALL_BRANCHES=y, so prevent PROFILE_ALL_BRANCHES if
> >> FORTIFY_SOURCE=y.
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > I'm actually working on a patch that I need to send to Linus before
> > 4.15 is released. Want me to add this one too? Or do you have your own
> > branch to push to mainline with?
>
> I don't have any branch to push. Please merge it whenever you think it's
> appropriate.
>
I'll take it. Thanks,
-- Steve
prev parent reply other threads:[~2018-01-15 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 19:07 Randy Dunlap
2018-01-15 19:10 ` Steven Rostedt
2018-01-15 19:12 ` Randy Dunlap
2018-01-15 19:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115141455.01cebe74@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®