From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966186AbeAOQ12 (ORCPT + 1 other); Mon, 15 Jan 2018 11:27:28 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51532 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933469AbeAOQ10 (ORCPT ); Mon, 15 Jan 2018 11:27:26 -0500 Date: Mon, 15 Jan 2018 08:27:26 -0800 From: Christoph Hellwig To: Mimi Zohar Cc: linux-integrity , linux-security-module , linux-fsdevel , linux-kernel , Dongsu Park , Alban Crequy , Christoph Hellwig , Seth Forshee Subject: Re: [PATCH] ima: define new policy condition based on the filesystem name Message-ID: <20180115162726.GB15686@infradead.org> References: <1516033236.6607.6.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516033236.6607.6.camel@linux.vnet.ibm.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 11:20:36AM -0500, Mimi Zohar wrote: > Some filesystems do not export the filesystem's magic number, as it is > considered internal, private data. In other cases, the policy rule > needs to identify a specifically mounted filesystem (eg. rootfs). No, it doesn't. Policies based on a file system type are complete and utterly bogus. rootfs should not be treated any different from other file systems.