From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751766AbeAOSBF (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 13:01:05 -0500
Received: from merlin.infradead.org ([205.233.59.134]:41766 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751733AbeAOSBD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 13:01:03 -0500
Date: Mon, 15 Jan 2018 19:00:55 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
        linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jun Nakajima <jun.nakajima@intel.com>,
        Asit Mallick <asit.k.mallick@intel.com>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 1/4] objtool: Implement base jump_assert support
Message-ID: <20180115180055.GB2269@hirez.programming.kicks-ass.net>
References: <20180115164428.498966552@infradead.org>
 <20180115164909.774177737@infradead.org>
 <20180115173928.7ajrdwah24jwxmku@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180115173928.7ajrdwah24jwxmku@treble>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, Jan 15, 2018 at 11:39:28AM -0600, Josh Poimboeuf wrote:
> Big props to you for braving the bowels of the objtool code.
> 
> On Mon, Jan 15, 2018 at 05:44:29PM +0100, Peter Zijlstra wrote:
> > +static int read_jump_assertions(struct objtool_file *file)
> 
> This does more than just _read_ the assertions.  Can you call it
> something like assert_static_jumps() or do_static_jump_assertions() and
> then call it from the main check() function?

Sure.

> > --- a/tools/objtool/check.h
> > +++ b/tools/objtool/check.h
> > @@ -45,6 +45,7 @@ struct instruction {
> >  	unsigned char type;
> >  	unsigned long immediate;
> >  	bool alt_group, visited, dead_end, ignore, hint, save, restore, ignore_alts;
> > +	bool br_static;
> 
> s/br_static/static_jump_dest/?

fair enough.

> Also, fellow objtool expert, you forgot the patch to the MAINTAINERS
> file ;-)

Well, uhm.. I'll think about it ;-)