From: Max Kellermann <mk@cm4all.com>
To: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
Cc: Max Kellermann <mk@cm4all.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@cavium.com>,
"max.kellermann@gmail.com" <max.kellermann@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout
Date: Mon, 15 Jan 2018 21:37:27 +0100 [thread overview]
Message-ID: <20180115203726.b7igf7rajczllcv7@rabbit.intern.cm-ag> (raw)
In-Reply-To: <13B82B86-8810-4722-97F9-EC5B862ECC76@cavium.com>
On 2018/01/15 20:58, "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> wrote:
> We have patch to prevent this double free in 4.16/scsi-queue
> already.
No, let me repeat: this is a different bug!
Your bug is about the free call after waiting for completion
synchronously in qla24xx_els_dcmd_iocb(), after it was already freed
by qla2x00_sp_timeout().
My bug is about free in qla2x00_*_sp_done() and again in
qla2x00_sp_timeout(). My patch description describes exactly that.
And you know what? My patch fixes both bugs. It is superior to the
one that was merged 4 weeks later, isn't it?
You NACKed my patch 5 weeks ago, and I explained to you that you were
talking about a different bug, but you never replied to that.
Max
next prev parent reply other threads:[~2018-01-15 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 17:26 Max Kellermann
2018-01-15 19:58 ` Madhani, Himanshu
2018-01-15 20:37 ` Max Kellermann [this message]
2018-01-15 21:03 ` Madhani, Himanshu
2018-01-18 1:02 ` Madhani, Himanshu
-- strict thread matches above, loose matches on Subject: below --
2017-12-07 14:46 Max Kellermann
2017-12-07 20:38 ` Madhani, Himanshu
2017-12-07 22:10 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115203726.b7igf7rajczllcv7@rabbit.intern.cm-ag \
--to=mk@cm4all.com \
--cc=Himanshu.Madhani@cavium.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=qla2xxx-upstream@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®