From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751002AbeAPEUu (ORCPT + 1 other); Mon, 15 Jan 2018 23:20:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33296 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbeAPEUt (ORCPT ); Mon, 15 Jan 2018 23:20:49 -0500 Date: Mon, 15 Jan 2018 22:20:46 -0600 From: Josh Poimboeuf To: Ingo Molnar Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Markus , Thomas Gleixner , Peter Zijlstra , Linus Torvalds Subject: Re: [PATCH 1/2] objtool: Fix seg fault with gold linker Message-ID: <20180116042046.soi3nmveue6utmtc@treble> References: <355f04da33581f4a3bf82e5b512973624a1e23a2.1516025651.git.jpoimboe@redhat.com> <20180116002144.w6tqxeojrubyanhe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180116002144.w6tqxeojrubyanhe@gmail.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 16 Jan 2018 04:20:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > Objtool seg faults when the gold linker is used with > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y. > > > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before > > being passed to objtool. The gold linker seems to strip unused ELF > > symbols by default, which confuses objtool and causes the seg fault when > > it's trying to generate ORC metadata. > > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into > a more useful failure message? Good point. I'll fix up this seg fault, and the other one found/introduced when adding retpoline support. -- Josh