From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750954AbeAPHq7 (ORCPT + 1 other); Tue, 16 Jan 2018 02:46:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:41361 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbeAPHq6 (ORCPT ); Tue, 16 Jan 2018 02:46:58 -0500 Date: Tue, 16 Jan 2018 08:46:56 +0100 From: Michal Hocko To: Robert Donald Rickett Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memory: fixed a coding style issue Message-ID: <20180116074656.GA17351@dhcp22.suse.cz> References: <20180116011712.eh4dswpm5f7jbeic@shadow1911> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116011712.eh4dswpm5f7jbeic@shadow1911> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon 15-01-18 19:17:12, Robert Donald Rickett wrote: > This is a patch to the memory.c file that fixes the > "ERROR: code indent should use tabs where possible" > found by the checkpatch.pl tool. Is this really worth it? The code is not any better readable and it just adds a churn to the history and makes life of anybody using git blame slightly more harder. So what is the benefit? > Signed-off-by: Robert Donald Rickett > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index ca5674cbaff2..e9f6e58aa77c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1663,7 +1663,7 @@ int zap_vma_ptes(struct vm_area_struct *vma, unsigned long address, > unsigned long size) > { > if (address < vma->vm_start || address + size > vma->vm_end || > - !(vma->vm_flags & VM_PFNMAP)) > + !(vma->vm_flags & VM_PFNMAP)) > return -1; > zap_page_range_single(vma, address, size, NULL); > return 0; > -- > 2.14.1 -- Michal Hocko SUSE Labs