From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 0/2] add tracepoints for nvme command submission and completion
Date: Tue, 16 Jan 2018 07:55:55 -0700 [thread overview]
Message-ID: <20180116145554.GB6259@localhost.localdomain> (raw)
In-Reply-To: <20180116142821.11693-1-jthumshirn@suse.de>
On Tue, Jan 16, 2018 at 03:28:19PM +0100, Johannes Thumshirn wrote:
> Add tracepoints for nvme command submission and completion. The tracepoints
> are modeled after SCSI's trace_scsi_dispatch_cmd_start() and
> trace_scsi_dispatch_cmd_done() tracepoints and fulfil a similar purpose,
> namely a fast way to check which command is going to be queued into the HW or
> Fabric driver and which command is completed again.
I like this very much, thanks for doing this. I think you could make the
submission trace point tighter for PCI as Hannes was suggesting since
an MMIO write can't fail, but doesn't look as doable for FC and RDMA.
next prev parent reply other threads:[~2018-01-16 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 14:28 Johannes Thumshirn
2018-01-16 14:28 ` [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd Johannes Thumshirn
2018-01-16 16:49 ` Christoph Hellwig
2018-01-17 7:46 ` Johannes Thumshirn
2018-01-16 14:28 ` [PATCH v2 2/2] nvme: add tracepoint for nvme_complete_rq Johannes Thumshirn
2018-01-16 16:50 ` Christoph Hellwig
2018-01-17 8:50 ` Johannes Thumshirn
2018-01-16 14:55 ` Keith Busch [this message]
2018-01-16 15:00 ` [PATCH v2 0/2] add tracepoints for nvme command submission and completion Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116145554.GB6259@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®