Re: [PATCH net-next v5 0/4] net: mvpp2: 1000BaseX and 2500BaseX support

[Russell King - ARM Linux <linux@armlinux.org.uk>]

On Fri, Jan 12, 2018 at 08:51:26AM +0100, Antoine Tenart wrote:
> Hi all,
> 
> This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2
> driver. In order to use it, the 2.5 SGMII mode is added in the Marvell
> common PHY driver (cp110-comphy).
> 
> This was tested on a mcbin.
> 
> All patches should probably go through net-next as patch 4/4 depends on
> patch 1/4 to build and work.
> 
> Please note the two mvpp2 patches do not conflict with the ACPI series
> v2 Marcin sent a few days ago, and the two series can be processed in
> parallel. (Marcin is aware of me sending this series).

As I've already said, we need to make sure things are done in a similar
way for all netdev DT drivers that are hoping to switch to phylink.
The mvneta patches are now in net-next for this.

What I can see is that there's a stark difference between mvpp2 and
mvneta and their handling of the "link irq" aka inband autonegotiation
status.

mvneta requires 'managed = "in-band-status";' to use the results of
the gmac negotiation otherwise inband AN is disabled.  As phylink was
developed against mvneta, phylink requires that for Base-X modes.

So, in order to be compatible with mvneta and to do what phylink expects,
specifying 'managed = "in-band-status";' is a requirement for Base-X
modes, and having that in place _now_ will make the transition to
phylink easier without creating the need to update DT when that change
happens.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up