From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Chen <tim.c.chen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Arjan Van De Ven <arjan.van.de.ven@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Asit Mallick <asit.k.mallick@intel.com>
Subject: Re: [PATCH v2 03/10] x86: Add a type field to alt_instr
Date: Tue, 16 Jan 2018 17:06:29 -0600 [thread overview]
Message-ID: <20180116230629.ods5wult5ejv7lwa@treble> (raw)
In-Reply-To: <20180116225325.pnjepmfeml3yvvgw@pd.tnic>
On Tue, Jan 16, 2018 at 11:53:25PM +0100, Borislav Petkov wrote:
> On Tue, Jan 16, 2018 at 04:49:55PM -0600, Josh Poimboeuf wrote:
> > Unfortunately it's against policy to include kernel headers from the
> > tools subdirectory, so we generally have to either hard code things like
> > this, or have a duplicated header file which needs to be kept in sync.
>
> Yeah, and AFAIR, perf tool guys already have machinery that does check
> whether stuff went out of sync and they resync the required definitions.
>
> You could reuse that...
We could, but it can be a real PITA to keep those files in sync, as they
often change for minor changes which don't even matter. So it might not
be worth the trouble. Objtool seems to complain when the alternatives
struct size changes anyway, so it's probably not a big deal.
--
Josh
next prev parent reply other threads:[~2018-01-16 23:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 14:28 [PATCH v2 00/10] objtool validation of static branches and retpoline Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 01/10] x86: Reindent _static_cpu_has Peter Zijlstra
2018-01-16 15:48 ` Borislav Petkov
2018-01-16 14:28 ` [PATCH v2 02/10] x86: Update _static_cpu_has to use all named variables Peter Zijlstra
2018-01-18 11:21 ` Borislav Petkov
2018-01-18 15:09 ` Peter Zijlstra
2018-01-18 15:24 ` Borislav Petkov
2018-01-16 14:28 ` [PATCH v2 03/10] x86: Add a type field to alt_instr Peter Zijlstra
2018-01-16 22:49 ` Josh Poimboeuf
2018-01-16 22:53 ` Borislav Petkov
2018-01-16 23:06 ` Josh Poimboeuf [this message]
2018-01-18 11:32 ` Borislav Petkov
2018-01-16 14:28 ` [PATCH v2 04/10] objtool: Implement base jump_assert support Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 05/10] x86: Annotate static_cpu_has alternative Peter Zijlstra
2018-01-18 13:15 ` Borislav Petkov
2018-01-16 14:28 ` [PATCH v2 06/10] objtool: Implement jump_assert for _static_cpu_has() Peter Zijlstra
2018-01-16 23:02 ` Josh Poimboeuf
2018-01-17 9:19 ` Peter Zijlstra
2018-01-17 14:27 ` Josh Poimboeuf
2018-01-17 14:30 ` Josh Poimboeuf
2018-01-17 16:30 ` Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 07/10] x86/jump_label: Implement arch_static_assert() Peter Zijlstra
2018-01-18 13:33 ` Borislav Petkov
2018-01-18 15:31 ` Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 08/10] objtool: Add retpoline validation Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 09/10] x86: Annotate dynamic jump in head_64.S Peter Zijlstra
2018-01-16 14:28 ` [PATCH v2 10/10] objtool: More complex static jump implementation Peter Zijlstra
2018-01-16 15:20 ` Peter Zijlstra
2018-01-17 3:05 ` Josh Poimboeuf
2018-01-17 8:18 ` Peter Zijlstra
2018-01-16 19:49 ` [PATCH v2 11/10] objtool: Even more complex static block checks Peter Zijlstra
2018-01-17 3:12 ` Josh Poimboeuf
2018-01-17 8:13 ` Peter Zijlstra
2018-01-17 14:13 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116230629.ods5wult5ejv7lwa@treble \
--to=jpoimboe@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®