From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-331097-1516221595-2-18126489326346521858 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516221595; b=tRzYIjenRoP9Pc78Pmi1reHE+6UfFajACcYdFf2f6LbrmV+ uii4H8kh1wPI16ihTfSCe7sbsuz2ffkEsw/VQzVSfDyM5UWiwk9gVYPckUTOwuL9 dwwUKlQEBmyBm8U0oIIGU0PVrleyi7VcGUnaTX4kEkoUt5F7RET633KKDHSE+n3X I6nn+hC8OYsZzt9nXIUTSDkJNoSecCO1mfwSu9L6b8niFR+hwcY+im+3KoT0fqFT CNapop3GrpYSFMtnFHtpiT9224G6Ul/tr7ziUOD/tA+CdUSksO15W9ltmyqI5GIb gh3X5qAgqW92YTSSkGEO0FihklpaDmJ8MfU8+VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:message-id:to:cc:subject:from :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516221595; bh=2eocA8rIB49lIVrLVL3QYJ7hs9znLiLthTLhyRT1en8=; b=Z DFffW4VgZLcTiHS0heaEtA9xqW5KbTIodCAOmJmJGbOJqXq2YstpBUZ7NVtogK0B /8jTxB3pUckHagDF0sUpbXTAQF7YUZU8NyKRxcvlITTuohUrPKkQeKj+BI2UJ8vd idFKb/cnVoJiIEs8kL0+x91HR7GCh+659KalHRBq1T3TwDViLAKU3XYohP4/qi4f JRmNReYMKhQERifQOQxPHqT20wrsWk3r6f6I+kh8Ap7XboW5fBfSioumsF/giAhR C21z6oHjxlOm928NfW6q4o3gwdUkoVwmrg5lKeDa8kgAkJHUovCWaOTYbOWbWZJk tXEwYm8YVa9aaFnnM8d5w== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=davemloft.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=davemloft.net header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=davemloft.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=davemloft.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932173AbeAQUje (ORCPT ); Wed, 17 Jan 2018 15:39:34 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753793AbeAQUjc (ORCPT ); Wed, 17 Jan 2018 15:39:32 -0500 Date: Wed, 17 Jan 2018 15:39:30 -0500 (EST) Message-Id: <20180117.153930.330864749049561139.davem@davemloft.net> To: kai.heng.feng@canonical.com Cc: hayeswang@realtek.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@dell.com Subject: Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock From: David Miller In-Reply-To: <20180116084627.12638-1-kai.heng.feng@canonical.com> References: <20180116084627.12638-1-kai.heng.feng@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Kai-Heng Feng Date: Tue, 16 Jan 2018 16:46:27 +0800 > r8153 on Dell TB15/16 dock corrupts rx packets. > > This change is suggested by Realtek. They guess that the XHCI controller > doesn't have enough buffer, and their guesswork is correct, once the RX > aggregation gets disabled, the issue is gone. > > ASMedia is currently working on a real sulotion for this issue. > > Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16. > > Note that TB15 has different bcdDevice and iSerialNumber, which are not > unique values. If you still have TB15, please contact Dell to replace it > with TB16. > > BugLink: https://bugs.launchpad.net/bugs/1729674 > Cc: Mario Limonciello > Signed-off-by: Kai-Heng Feng > --- > v2: > - Disable RX aggregation instead of disable RX checksum > - Use bcdDevice and iSerialNumber to uniquely identify Dell TB16 Ok, since this is very restricted it's an acceptable way to deal with this problem. Applied, thanks.