From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbeAQQ0C (ORCPT ); Wed, 17 Jan 2018 11:26:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:59020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbeAQQZ7 (ORCPT ); Wed, 17 Jan 2018 11:25:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530AE20C0F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 17 Jan 2018 11:25:56 -0500 From: Steven Rostedt To: Paul Menzel Cc: Ingo Molnar , linux-kernel@vger.kernel.org, regression@leemhuis.info, Mario Limonciello , Len Brown , "Rafael J. Wysocki" Subject: Re: Suspend/resume with FTRACE enabled =?UTF-8?B?ZG9lc27igJl0?= work anymore Message-ID: <20180117112556.7bc7fe0f@gandalf.local.home> In-Reply-To: <20180117111943.75cac2dd@gandalf.local.home> References: <696324c4-0a21-8ee8-1ff8-e90e87020ff7@molgen.mpg.de> <20180117111031.69f46195@gandalf.local.home> <20180117111943.75cac2dd@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jan 2018 11:19:43 -0500 Steven Rostedt wrote: > On Wed, 17 Jan 2018 11:10:31 -0500 > Steven Rostedt wrote: > > > > It's been fixed, and the the patch is in Linus's tree already: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0e3a18f4baf8e3754ac1e56f0ade924d0c0c721 > > Although I just noticed that the revert, also reverted the required > barriers. I'll go add them back in. > I take that back. Barriers are not needed, as interrupts do not need to see the updates. And looking at the patch being reverted, I don't think they were needed there either. The update to those bits only need to be done for the current context to prevent recursion at that context. And that was the case with the commit that was reverted. -- Steve