From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbeAQNf1 (ORCPT + 1 other); Wed, 17 Jan 2018 08:35:27 -0500 Received: from mail-eopbgr30129.outbound.protection.outlook.com ([40.107.3.129]:45475 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753129AbeAQNeh (ORCPT ); Wed, 17 Jan 2018 08:34:37 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Linus Walleij , Andrew Jeffery , Charles Keepax , linux-gpio@vger.kernel.org Subject: [PATCH 1/3] pinctrl: sx150x: unregister the pinctrl on release Date: Wed, 17 Jan 2018 14:34:21 +0100 Message-Id: <20180117133423.4482-2-peda@axentia.se> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180117133423.4482-1-peda@axentia.se> References: <20180117133423.4482-1-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [85.226.244.23] X-ClientProxiedBy: AM3PR03CA0062.eurprd03.prod.outlook.com (2603:10a6:207:5::20) To VI1PR0202MB2783.eurprd02.prod.outlook.com (2603:10a6:800:db::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86313db8-2803-49ef-8ba6-08d55daf0bc9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:VI1PR0202MB2783; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2783;3:RVJrnLeliqLduHj0iQsxSWLA+NTa3tCxpuhPn+yJBg0Zz9V3x4PfRjpbv6yFjACsVcdE1omERfCQbqGqar9sKVyOQtAtRPCdzKn6lf7KkX2tZnSvmJtg+Y/G0HNrJehiByvd/zBqlmxDKEIEauuweydYfmiwurDzYN2Y4A0pQWTqH1YXHsuFnOxMp8ELF5dz6ZLjAxm4MLwScPQ0Knrkee32GSTqDRVYY0gi/47AqBTr22TY+0ljNmRcF4h5cNJ3;25:FFts8A5u68Ilmsi6qwS4fwZA/0YVX7Xg76S3I+NMg5r3hWKc+xbGccUXuYBulASTr+3g3HjyeZmL8A2IY39i+/uLJhIBcz3P79D8FpNVlntg/h/Abj5tg6wki0CE8BoDTieRJYJWLbPlSZF0uOkki15gXhfNQZasfArz+9ejk6SQ7VcuAQfIzqJI5nJRYS1LmIbsvSzwVhMf5QHWvuPYRHGRAx6mk7GW/Mn6BKHDu8UgBKIdRmzsQ4m2If5j/Og1zLfZY4WbgA9ccSnWdVtcWruskSbuEbCBvu2pbIJiqjIG1uRfo+piZeNe+gjeOVu8yB3or9XhiD3Mre6nn5FAww==;31:Do3lGOdpXw696VHDsjMY/a9hiC+jD/8jW5N21ma6gMvle0XtetyZ7s0M4vrX9SFzmq0qsO/tOPMQ6WODEJa5nj3lVnCfliyNQScTxRb6f58Pm/xaSQA3ocwWwPpGk8R10rENo9PyVttkOil1cRSkLvCAYGkUQ8bByTUQhf/i49LeLLAKyoDPLjbs6qDVjtmU0gaV7N/8zZ8fyUlae4S4VnL6AwyYAiabd+ClZWOv04E= X-MS-TrafficTypeDiagnostic: VI1PR0202MB2783: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(944501161)(93006095)(93001095)(3002001)(6041268)(2016111802025)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6043046)(6072148)(201708071742011);SRVR:VI1PR0202MB2783;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0202MB2783; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2783;4:1KsYt3UHMteffwdio6zPziQpZWYlYDlM+4Z/7B8urEBhZFVkdsRwiGEoX9zDcHZ5wRDyWN3bzYCq+Thlzl5VCyfT/WUdbSdKcmjloPbrHUi7fXkZi10fi3WvXZcHVcsPqNqXtxQopR/GyPGHDSf2abdx/b0kRabQma9VnAnzYtptBDK+R5/vrBTSeNTB5A2g/5Utg+C3A4jPkqKzsaIhbaPGj94YlFZWZpPBr/vCcwdz2A3NlnBtni7I7cqKiuLK+oK97BnLphSxh5aCyqnE4w== X-Forefront-PRVS: 0555EC8317 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(346002)(39830400003)(376002)(396003)(39380400002)(366004)(199004)(189003)(7736002)(81156014)(50226002)(2950100002)(478600001)(26005)(59450400001)(76176011)(51416003)(52116002)(16526018)(4326008)(6666003)(2351001)(2361001)(105586002)(106356001)(1076002)(97736004)(36756003)(66066001)(86362001)(74482002)(50466002)(47776003)(6116002)(3846002)(316002)(386003)(48376002)(6512007)(6506007)(6486002)(6916009)(16586007)(25786009)(5660300001)(53936002)(305945005)(8936002)(81166006)(2906002)(68736007)(8676002)(54906003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2783;H:orc.pedanet;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0202MB2783;23:OLpg3T+iubYDQzz8AxVDMF953epb/5rpmSwrWFO?= =?us-ascii?Q?4udjQnw4en+KuzyCNBF2RAyJvvdD8waCG5viInnW6hYkMK32ADHpR1O8y9SD?= =?us-ascii?Q?TqI2pGrMsEk1sffK3DW+Qrx97E36Hsd+JSp2hXu9/4xyFds8k4W2U73kDOEx?= =?us-ascii?Q?3kqjVXNAy5Z7iX2PSJRhQwFwaHP2oXqRlNz7ogWFEFhICunzywLekhvkthqk?= =?us-ascii?Q?uBQ5gSpsHCq7eSoeBpRmN51IWI/OnwBipTRBEzALkcpzJFgiepzPqd86CG7r?= =?us-ascii?Q?9xOpvXjAHM5CSyYKsGJZywKn3dHGheLWvmls9ggpRvbJNeVyVSz4AYXi0BA8?= =?us-ascii?Q?RzVYSIjBK/uapHDC3SSxfaXs4rStVUtHiotMW2X40L+MfKwN/2eAKW8crt/n?= =?us-ascii?Q?oNlxzPRFpUpS00latbv80MwBBHzxxClh3+6fWv3h8SetXKYiidVGIg5FwxOf?= =?us-ascii?Q?w5g9bWzjAuNPhbfKl4vtzopOYPaX0bbnefXifvG6nDbfTLMhpfn7+GH+oho6?= =?us-ascii?Q?+TPKctcCGLCyHkIUvIvsvBp/LvDN7e52Cmp7cKTlr4VBv/aRIPTQ+A60o5YL?= =?us-ascii?Q?eY5ReGADKvEo+U/2zmdubWS0rNHV0mRR9nAhwQdfy/gkfkBjdzGCu/0/zjXg?= =?us-ascii?Q?UVYHFvrW4/oHrB4WHgsxHd2vZfuM1Jy1g7TaIoX7+m7xqHwn4A4/V7KoJKkd?= =?us-ascii?Q?usHJXPgCrC0EqZugyx37C7UmLSewCeUJ6zcixSx1pcAsoDnV/XQB8zYqy5sx?= =?us-ascii?Q?hjDw9jwTr+F3zswhD64b+xdu2UCoVWdgFnJ3juDEjEHabDg9XdGWX0QtNRZ/?= =?us-ascii?Q?ZIMNPZmKajYpwDZNV8w0Fi1l/cuQctYFB7fHROkNVJfcR6rDKqMxi9NjGGya?= =?us-ascii?Q?xzqS4h2F1yrPbFiWRW58ZcsBBdGvbH6P9YocbGxefFeWtygOsLJfDduBaBoK?= =?us-ascii?Q?pPgjIr5Y7pBcIVWgde7LaFVuNYOH+ONVJtHEbxzD7NeuhBlMSxUgp/vLmnug?= =?us-ascii?Q?FkYHTnuJiMSAM9SBcTNYTJeo8/P3UWy+rYyq21yT82wNoxDih/zdVXMXIqVo?= =?us-ascii?Q?jjD+21t+sfJVg1XFUCAGWxefibsX4Z/LZGkQ64YH6IFVKeoleQb5tmBAzIVe?= =?us-ascii?Q?cvpPe4JWGEEri0d8JjZmRK1+MPNSifS1SEnhlvfD+dVOm0pG+mVmkcGnzqrc?= =?us-ascii?Q?eyc+mwzqEvgoEyWlVyP0JZfv0AJxXQvGHWbdrop3sRKFdfNnHjx2Fwwg7tQ?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2783;6:QP44JJJ2H7n18AXsExVfPSAv3XTcUB5qiyB0hLwzXXaKqSZTU+E7dyesv6r72/7Sxt+YZNPX5GIc3PUm8xS1cepLDetUY3Xwx9H3HxdUFB3sta9eFFTg0T+6lkDEt7nm5pdloM0RkqMrTU1NYvxc2VROCajmFQTu/z5jGRGGfOyJAQsgESBbu6+Olg+I9hRteEqsdnrckGSmZbMbxBoZF/zRmwS3gXGw4MuXjpS5LEv/Fgs2dI+Yfdv3n/y2b3BElAdkKYnV4MLWyN3iQxA/G6rXz8vfUrE+p8+rYOYm2oXqT3FhlJxa93+9yMqqRotAwI9qOQAwsdENhUrJTJHejr9YeDmIJ2CSI/n1UQ6GTiU=;5:YfUN9PhdM0E+XJCDXOWsJKBwxVCr05wT5YatS3xpZjqldaDiWNO35osv7MPTM4crh5vIF0mDVj2AutnoR4TmbQ6GtwRP5Z/Nby3CoPr9+PBglBNkqUC7ZrrKmuYkII3c3lVf5wWgpGqDzlHNN9Pd81cEb9q/KOSEnUk8WNU/mJ0=;24:t3FcTUUT7LULclL1ygsypiTVGrEe422wKlgDnqNJUJEEQC7oqiMCgb1tQuP0pVkczMtGfhoPU1PJ6BFfLFBYhzLqteS4pyQmrIN91vYJKxM=;7:axj4ArfOuf77nr2vhKzJa2FK8spLPBdT/Y/kgCYHfQ2LMi4OvkhHU72QgQlN/XpucJoCnGD8O9JLUndnp+D75J+T5SxZQycid8NqTKb8CS9k2QsVlwGM2Mnw3Wy6jD84WGUYX0arZf3KjbW+NnnBMUtcA2m6wrOtXmf3NnZ6/AY6l21PjkDMvrnRjMOIL6GA30LQBLHY1RQJ0jkG0Spokfcoe/ELAgo56R9aVsQOiZdT+9NeQ9s9Kd53wUGwFMht SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 13:34:33.6836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86313db8-2803-49ef-8ba6-08d55daf0bc9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2783 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: There is no matching call to pinctrl_unregister, so switch to the managed devm_pinctrl_register to clean up properly when done. Fixes: 9e80f9064e73 ("pinctrl: Add SX150X GPIO Extender Pinctrl Driver") Signed-off-by: Peter Rosin --- drivers/pinctrl/pinctrl-sx150x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index fb242c542dc9..f926ba044577 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -1225,7 +1225,7 @@ static int sx150x_probe(struct i2c_client *client, pctl->pinctrl_desc.npins = pctl->data->npins; pctl->pinctrl_desc.owner = THIS_MODULE; - pctl->pctldev = pinctrl_register(&pctl->pinctrl_desc, dev, pctl); + pctl->pctldev = devm_pinctrl_register(dev, &pctl->pinctrl_desc, pctl); if (IS_ERR(pctl->pctldev)) { dev_err(dev, "Failed to register pinctrl device\n"); return PTR_ERR(pctl->pctldev); -- 2.11.0