From: Joerg Roedel <joro@8bytes.org>
To: Peter Xu <peterx@redhat.com>
Cc: iommu@lists.linux-foundation.org,
Alex Williamson <alex.williamson@redhat.com>,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: use domain instead of cache fetching
Date: Wed, 17 Jan 2018 14:46:07 +0100 [thread overview]
Message-ID: <20180117134606.duf22tresqonahmt@8bytes.org> (raw)
In-Reply-To: <20180110055137.5711-1-peterx@redhat.com>
On Wed, Jan 10, 2018 at 01:51:37PM +0800, Peter Xu wrote:
> after commit a1ddcbe93010 ("iommu/vt-d: Pass dmar_domain directly into
> iommu_flush_iotlb_psi", 2015-08-12), we have domain pointer as parameter
> to iommu_flush_iotlb_psi(), so no need to fetch it from cache again.
>
> More importantly, a NULL reference pointer bug is reported on RHEL7 (and
> it can be reproduced on some old upstream kernels too, e.g., v4.13) by
> unplugging an 40g nic from a VM (hard to test unplug on real host, but
> it should be the same):
>
[...]
>
> CC: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> drivers/iommu/intel-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2018-01-17 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 5:51 Peter Xu
2018-01-10 23:50 ` Alex Williamson
2018-01-17 13:46 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117134606.duf22tresqonahmt@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®