From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165AbeAQPgC (ORCPT ); Wed, 17 Jan 2018 10:36:02 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:42755 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbeAQPfq (ORCPT ); Wed, 17 Jan 2018 10:35:46 -0500 X-Google-Smtp-Source: ACJfBouJCZjWpzgmXoYL+Mp/zJ5YmdDsp/ZZ8SLudpTwjfNcU42MXoxPcL+P3k9v1EiMsoG+GOKSdA== Date: Wed, 17 Jan 2018 16:35:44 +0100 From: Jiri Pirko To: Colin King Cc: Jiri Pirko , "David S . Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][devlink-next] devlink: make functions a couple of new functions static Message-ID: <20180117153544.GG2114@nanopsycho> References: <20180117112303.20149-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117112303.20149-1-colin.king@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Jan 17, 2018 at 12:23:03PM CET, colin.king@canonical.com wrote: >From: Colin Ian King > >The functions devlink_resource_find and devlink_resource_validate_children >are local to the source and do not need to be in global scope, so make >them static. > >Cleans up sparse warnings: >symbol 'devlink_resource_find' was not declared. Should it be static? >warning: symbol 'devlink_resource_validate_children' was not declared. >Should it be static? > >Signed-off-by: Colin Ian King This is already submitted here: http://patchwork.ozlabs.org/patch/862020/