From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbeAQVPX (ORCPT ); Wed, 17 Jan 2018 16:15:23 -0500 Received: from 9pmail.ess.barracuda.com ([64.235.154.211]:52134 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753887AbeAQVPS (ORCPT ); Wed, 17 Jan 2018 16:15:18 -0500 Date: Wed, 17 Jan 2018 21:13:39 +0000 From: James Hogan To: Mathieu Malaterre CC: Ralf Baechle , Steven Rostedt , Ingo Molnar , , Subject: Re: [PATCH] MIPS: ftrace: Remove pointer comparison to 0 in prepare_ftrace_return Message-ID: <20180117211339.GB27409@jhogan-linux.mipstec.com> References: <20180117113157.25768-1-malat@debian.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wwSFAA0Com6UqrPP" Content-Disposition: inline In-Reply-To: <20180117113157.25768-1-malat@debian.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [192.168.154.110] X-BESS-ID: 1516223666-321457-32186-5898-1 X-BESS-VER: 2017.17-r1801171719 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.189084 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wwSFAA0Com6UqrPP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 17, 2018 at 12:31:57PM +0100, Mathieu Malaterre wrote: > Replace pointer comparison to 0 with NULL in prepare_ftrace_return > to improve code readability. Identified with coccinelle script > 'badzero.cocci'. >=20 > Signed-off-by: Mathieu Malaterre Reviewed-by: James Hogan Cheers James > --- > arch/mips/kernel/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c > index 99285be0e088..7f3dfdbc3657 100644 > --- a/arch/mips/kernel/ftrace.c > +++ b/arch/mips/kernel/ftrace.c > @@ -361,7 +361,7 @@ void prepare_ftrace_return(unsigned long *parent_ra_a= ddr, unsigned long self_ra, > * If fails when getting the stack address of the non-leaf function's > * ra, stop function graph tracer and return > */ > - if (parent_ra_addr =3D=3D 0) > + if (parent_ra_addr =3D=3D NULL) > goto out; > #endif > /* *parent_ra_addr =3D return_hooker; */ > --=20 > 2.11.0 >=20 >=20 --wwSFAA0Com6UqrPP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlpfvIMACgkQbAtpk944 dnrrfhAAjQRR+6kWFQh0Xt71sQZEBS3b1bNi81tc+yvwICe7sj1OQ8Jwn2YkWgRH gjcBfAdBQYtCFrxWSnvBOZVVbtuYnfwFLyG66RZ0poaIs8Wl72o6Um4gSGpXgBlb IS+Y27GYbNgCE86rBU6BwHe5HoYbi4TKRmqS2W29BrcZZ1iSe24Os89m43aOq6Vg J+tETr/E4egZPoR9kAtYgEGPbsegRxnnfdehM9FT7/SgN0pFMQ84snq05tDXCwYZ X4CPp0rdO3LqCSAh57zvqoTD1jveQv0vQzIb70efRtYE9M71KHZFIP3QFjB5uvqw OYJk9aIjYHVE4uq+0rqFCBHnUW7FTYn24uz/8jUctJ8gisc/ETO1/QuHumee7BOD CSEndG6xl+m9QtkbWUtyzHPP51kUZhHKpCgVQVfG5lfIht79APVf2wrrH6PfQfwK OvTt75iNfIr6eybsKL0dv+AayaZsz2n86bsroTUxLLWlNW6zlO7zSbcOOxaZEn6T C5dYth//jmqF7Mjngfn32qKj43n1lEsEPwSD3xlin+85vzV91W62WAsDFKAgJT4h nZ4TiXRM6eYzlpgdrcLI6z4IW+a9pVTBv0xDHslCyc9iSbdP6dsvUE52eudAOxQ3 pHZyBVxEBEmo4y2Vf0L56owswxjBJ9wg524+YfZfvZPZkHgRQWc= =mal1 -----END PGP SIGNATURE----- --wwSFAA0Com6UqrPP--