From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1922647-1516287091-2-4605019257955863767 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516287091; b=R4UMYzuEl2v7lV5tITCR5ZfuBhpslfjNCucWWuHQqZZ50ks SouwWXCJPGQWvTwVKUoVEP5Jt95ygJTf1q7QELJswv/utUs5tbMEkqs1Zz+9tNnf i9nQ+PaFM65/n+QbGaWxbswyy/cn4JISGCZb+FGZHZlJC7yy2FEFtJQXU2FrH8rS EDwMflTsIgIx7sz+ISOidheoebv+yER814aavfYMs9URlJB6j7AyhS7cokTqXKVf gnEPkFJPML0NxCtIT+FMJYPnCTzAx3sfrHlfJwyJ95tT00XZumgYOgSD1J7S4NTE jGSHLEbexzCAzY+Izre7ORQKLjJ+6NDzDMfDGEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:message-id:to:cc:subject:from :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516287091; bh=SS3YsZgJ0V3uXaHptTyNiROQ2eoQF0HQ6LrOwqxdfGI=; b=F bev023bnSYwtjBFCX8PhL2Qbz1mPB3HpEvc/kXTVlcZLlSc4oJXXlKTBl6+H8Gry 0n/H4pmda9YQKApoyvhKU10SflxSl+uE93jaji9dgjWY17+KRcCc6+UBEYsF2PTv 8xh5yAigoKUE8P575mlM2OG7stVi6VzP8J7lEbIqQf2U41usFSBWo7QZdGdM7Z7Z OUuBv+KN530DSmE2yYBw6AUkPLuGGs6VPkSui0LnZD0EM6yPNurw9RaqdFF2c1OW N0hZ8Dn9oow6F/Aj3jF2HnjArk8DDMcR/V6NcoWGcrmqNslrMiCiombK8b/G25Ue A4gSq07P3/4qd2ZAbQPXg== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=davemloft.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=davemloft.net header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=davemloft.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=davemloft.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756571AbeAROu1 (ORCPT ); Thu, 18 Jan 2018 09:50:27 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51840 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756559AbeAROuY (ORCPT ); Thu, 18 Jan 2018 09:50:24 -0500 Date: Thu, 18 Jan 2018 09:50:22 -0500 (EST) Message-Id: <20180118.095022.1121845945987753430.davem@davemloft.net> To: hayeswang@realtek.com Cc: kai.heng.feng@canonical.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@dell.com, nic_swsd@realtek.com Subject: Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock From: David Miller In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2D2E16D63@RTITMBSV06.realtek.com.tw> References: <20180116084627.12638-1-kai.heng.feng@canonical.com> <20180117.153930.330864749049561139.davem@davemloft.net> <0835B3720019904CB8F7AA43166CEEB2D2E16D63@RTITMBSV06.realtek.com.tw> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Hayes Wang Date: Thu, 18 Jan 2018 03:04:08 +0000 > [...] >> > r8153 on Dell TB15/16 dock corrupts rx packets. >> > >> > This change is suggested by Realtek. They guess that the XHCI >> > controller doesn't have enough buffer, and their guesswork is correct, >> > once the RX aggregation gets disabled, the issue is gone. >> > >> > ASMedia is currently working on a real sulotion for this issue. >> > >> > Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16. >> > >> > Note that TB15 has different bcdDevice and iSerialNumber, which are >> > not unique values. If you still have TB15, please contact Dell to >> > replace it with TB16. > > Excuse me. I don't understand why this patch is for specific USB nic rather than xHCI. > It seems to make the specific USB nic working and the other ones keeping error. Well, are we sure that the device being in the TB16 dock doesn't contribute to the issue as well? If the problem only shows up with XHCI and this dock, then this patch was the appropriate way to deal with the problem for now.